Skip to content

fix(build-node): preserve Bun linker for node-pty install - #20364

Merged
Hona merged 3 commits into
anomalyco:refactor/hono-serverfrom
Hona:fix/build-node-linker-detection
Apr 1, 2026
Merged

fix(build-node): preserve Bun linker for node-pty install#20364
Hona merged 3 commits into
anomalyco:refactor/hono-serverfrom
Hona:fix/build-node-linker-detection

Conversation

@Hona

@HonaHona commented Mar 31, 2026

Copy link
Copy Markdown
Member

Summary

  • detect whether the current Bun install layout is hoisted or isolated before the follow-up bun install
  • pass the same linker when installing @lydell/node-pty so the Windows GITHUB_ACTIONS path does not mix hoisted and isolated installs
  • keep build-node.ts aligned with the existing install method instead of falling back to the monorepo default

Testing

  • GITHUB_ACTIONS=true bun --cwd packages/opencode script/build-node.ts
  • bun turbo typecheck (via pre-push hook)

CopilotAI review requested due to automatic review settings March 31, 2026 22:44

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the packages/opencode Node build script to ensure that when it runs a follow-up bun install for @lydell/node-pty, it uses the same Bun linker mode (hoisted vs isolated) as the current workspace install layout—avoiding mixed install layouts (notably on Windows in GITHUB_ACTIONS).

Changes:

  • Add linker-mode detection by inspecting workspace/root node_modules placement (with a fallback based on bun.lock + workspace config).
  • Pass --linker=<detected> to the bun install ... @lydell/node-pty@... step in build-node.ts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HonaHona added the beta label Mar 31, 2026
@Hona
Hona merged commit 529a4d5 into anomalyco:refactor/hono-serverApr 1, 2026
4 of 6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hona