Skip to content

refactor(instruction): complete new service migration - #20574

Closed
kitlangton wants to merge 1 commit into
effect/instructionfrom
effect/instruction-followups
Closed

refactor(instruction): complete new service migration#20574
kitlangton wants to merge 1 commit into
effect/instructionfrom
effect/instruction-followups

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

  • switch the instruction service to AppFileSystem and Effect HTTP helpers so it matches the rest of the refactor
  • update prompt.ts and read.ts to use the new Instruction API and remove the old InstructionPrompt path
  • expand instruction tests to cover claim clearing and already-loaded instruction metadata

Testing

  • bun typecheck
  • bun run test test/session/instruction.test.ts

@kitlangton

Copy link
Copy Markdown
ContributorAuthor

Closing this follow-up PR and folding its commit into #20542 so the instruction work stays in a single PR.

@kitlangton
kitlangton deleted the effect/instruction-followups branch April 2, 2026 01:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kitlangton