Uh oh!
There was an error while loading. Please reload this page.
feat(session): harden per-session SQLite sharding - #21012
Closed
sjawhar wants to merge 4 commits into
Closed
Conversation
sjawhar
commented
Apr 4, 2026
Author
Review guide for this PR: This PR is intentionally core-only. It does not contain the Postgres implementation; that lives in the external plugin PR at sjawhar/opencode-postgres-sync#1. Please focus review on three things:
|
sjawharforce-pushed
the
feat/session-sharding-resume-hooks
branch
from
April 5, 2026 03:28
515595f to
dd37895Comparesjawharforce-pushed
the
feat/session-sharding-resume-hooks
branch
2 times, most recently
from
April 6, 2026 18:01
685d3b7 to
343636aComparetest: add resolve() routing tests for shard/global DB routing 4 tests covering the sharding contract: - hasSession returns true from cache after Session.create() - Database.session() returns shard DB, not global DB - Cold cache uses 8KB file size threshold - Session list queries global DB regardless of shards - hasSession rejects empty/malformed shard files Prevents regression of the resolve() routing that broke when root_session_id was removed.
sjawharforce-pushed
the
feat/session-sharding-resume-hooks
branch
from
April 8, 2026 18:38
343636a to
cdc980fCompareContributor
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
sjawharforce-pushed
the
feat/session-sharding-resume-hooks
branch
from
April 8, 2026 20:02
cdc980f to
fca4d2dComparesjawharforce-pushed
the
feat/session-sharding-resume-hooks
branch
from
April 8, 2026 20:30
fca4d2d to
9966cb2CompareContributor
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLITE_BUSY*retries with backoff/jitteropencode-postgres-syncdist matches the sibling build and capture execution evidence under.sisyphus/evidenceVerification
bun test test/storage/retry.test.ts test/storage/pragma.test.ts test/storage/db.test.ts test/storage/wal-monitoring.test.ts test/storage/checkpoint-monitoring.test.ts test/storage/write-metrics.test.ts test/session/concurrency-load.test.tsOPENCODE_LOAD_SOAK_MS=300000 bun test test/session/concurrency-load.test.ts -t "soaks multi-process contention for the configured duration"bun testin/home/ubuntu/opencode/opencode-postgres-syncbun run buildin/home/ubuntu/opencode/opencode-postgres-syncdiff -qr /home/ubuntu/opencode/opencode-postgres-sync/dist /home/ubuntu/opencode/db/packages/opencode-postgres-sync/distNotes
< 3.51.3remains expected on this machine