Uh oh!
There was an error while loading. Please reload this page.
delete all e2e tests - #22501
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the existing Playwright-based E2E harness and its supporting “test probe” instrumentation from both the app and opencode backend, leaving only a minimal placeholder E2E spec while updating Playwright.
Changes:
- Remove E2E-only backend hooks (e.g.,
OPENCODE_E2E_LLM_URL) and the opencode E2E seeding script. - Delete the app’s E2E test suite + harness utilities, and remove app-side E2E probe instrumentation (
__opencode_e2e,data-pty-id, etc.). - Update Playwright dependency and adjust the
test:e2e:localscript.
Reviewed changes
Copilot reviewed 77 out of 78 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/opencode/src/tool/registry.ts | Removes E2E-based tool gating for patch/edit/write selection. |
| packages/opencode/src/provider/provider.ts | Removes E2E-only LLM baseURL override via OPENCODE_E2E_LLM_URL. |
| packages/opencode/script/seed-e2e.ts | Removes opencode-side E2E session/project seeding script. |
| packages/app/src/testing/terminal.ts | Removes terminal E2E probe/driver utilities. |
| packages/app/src/testing/session-composer.ts | Removes composer dock E2E driver/probe utilities. |
| packages/app/src/testing/prompt.ts | Removes prompt E2E probe utilities. |
| packages/app/src/testing/model-selection.ts | Removes model-selection E2E probe/controls. |
| packages/app/src/pages/session/terminal-panel.tsx | Removes terminal focus E2E probe stepping. |
| packages/app/src/pages/session/composer/session-todo-dock.tsx | Removes composer dock E2E probe updates/cleanup. |
| packages/app/src/pages/session/composer/session-composer-state.ts | Removes E2E driver override path for todos/live state. |
| packages/app/src/pages/error.tsx | Removes E2E error-boundary console logging hook. |
| packages/app/src/context/local.tsx | Removes model-selection E2E probe binding and cleanup. |
| packages/app/src/components/terminal.tsx | Removes terminal E2E probe wiring and data-pty-id attribute. |
| packages/app/src/components/prompt-input/submit.ts | Removes prompt-send E2E probe events. |
| packages/app/src/components/prompt-input.tsx | Removes prompt popover E2E probe updates/cleanup. |
| packages/app/script/e2e-local.ts | Removes local E2E runner that bootstrapped backend + seed + Playwright. |
| packages/app/package.json | Updates Playwright version; changes test:e2e:local to run Playwright directly. |
| packages/app/e2e/utils.ts | Removes E2E SDK/helpers and constants used by the old harness. |
| packages/app/e2e/tsconfig.json | Stops including removed app testing files in E2E TS config. |
| packages/app/e2e/todo.spec.ts | Adds a placeholder/disabled E2E test. |
| packages/app/e2e/thinking-level.spec.ts | Deletes E2E spec (model variant cycle). |
| packages/app/e2e/terminal/terminal.spec.ts | Deletes E2E spec (terminal toggle). |
| packages/app/e2e/terminal/terminal-tabs.spec.ts | Deletes E2E spec (terminal tabs persistence/rename/close). |
| packages/app/e2e/terminal/terminal-reconnect.spec.ts | Deletes E2E spec (terminal reconnect behavior). |
| packages/app/e2e/terminal/terminal-init.spec.ts | Deletes E2E spec (terminal init / new tab). |
| packages/app/e2e/status/status-popover.spec.ts | Deletes E2E spec (status popover navigation/close). |
| packages/app/e2e/sidebar/sidebar.spec.ts | Deletes E2E spec (sidebar collapse/persistence). |
| packages/app/e2e/sidebar/sidebar-session-links.spec.ts | Deletes E2E spec (sidebar session navigation). |
| packages/app/e2e/sidebar/sidebar-popover-actions.spec.ts | Deletes E2E spec (sidebar popover behaviors). |
| packages/app/e2e/settings/settings.spec.ts | Deletes E2E specs (settings dialog + persistence scenarios). |
| packages/app/e2e/settings/settings-providers.spec.ts | Deletes E2E specs (custom provider form). |
| packages/app/e2e/settings/settings-models.spec.ts | Deletes E2E specs (model visibility/picker). |
| packages/app/e2e/settings/settings-keybinds.spec.ts | Deletes E2E specs (keybind editing/reset/conflicts). |
| packages/app/e2e/session/session.spec.ts | Deletes E2E spec (session CRUD/share flows). |
| packages/app/e2e/session/session-undo-redo.spec.ts | Deletes E2E spec (undo/redo flows). |
| packages/app/e2e/session/session-review.spec.ts | Deletes E2E specs (review panel/comment overflow/scroll). |
| packages/app/e2e/session/session-model-persistence.spec.ts | Deletes E2E spec (model persistence across sessions/workspaces). |
| packages/app/e2e/session/session-composer-dock.spec.ts | Deletes E2E specs (composer dock question/permission/todos). |
| packages/app/e2e/session/session-child-navigation.spec.ts | Deletes E2E spec (child session navigation regression). |
| packages/app/e2e/selectors.ts | Deletes shared E2E selector helpers. |
| packages/app/e2e/prompt/prompt.spec.ts | Deletes E2E spec (prompt send + assistant reply). |
| packages/app/e2e/prompt/prompt-slash-terminal.spec.ts | Deletes E2E spec (slash terminal toggle). |
| packages/app/e2e/prompt/prompt-slash-share.spec.ts | Deletes E2E spec (slash share/unshare). |
| packages/app/e2e/prompt/prompt-slash-open.spec.ts | Deletes E2E spec (slash open file picker). |
| packages/app/e2e/prompt/prompt-shell.spec.ts | Deletes E2E spec (shell mode execution + UI state). |
| packages/app/e2e/prompt/prompt-multiline.spec.ts | Deletes E2E spec (shift+enter multiline). |
| packages/app/e2e/prompt/prompt-mention.spec.ts | Deletes E2E spec (file @mention). |
| packages/app/e2e/prompt/prompt-history.spec.ts | Deletes E2E spec (prompt history navigation). |
| packages/app/e2e/prompt/prompt-footer-focus.spec.ts | Deletes E2E spec (footer controls restore focus). |
| packages/app/e2e/prompt/prompt-drop-file.spec.ts | Deletes E2E spec (drop image attachment). |
| packages/app/e2e/prompt/prompt-drop-file-uri.spec.ts | Deletes E2E spec (drop file URI). |
| packages/app/e2e/prompt/prompt-async.spec.ts | Deletes E2E specs (async prompt endpoint regression + restore input). |
| packages/app/e2e/prompt/mock.ts | Deletes E2E request-body match helpers for mock LLM flows. |
| packages/app/e2e/prompt/context.spec.ts | Deletes E2E specs (context panel open/close/actions). |
| packages/app/e2e/projects/workspaces.spec.ts | Deletes E2E specs (workspace CRUD/reorder/reset). |
| packages/app/e2e/projects/workspace-new-session.spec.ts | Deletes E2E spec (new sessions from workspace actions). |
| packages/app/e2e/projects/projects-switch.spec.ts | Deletes E2E specs (project switching behavior). |
| packages/app/e2e/projects/projects-close.spec.ts | Deletes E2E spec (closing active project navigates correctly). |
| packages/app/e2e/projects/project-edit.spec.ts | Deletes E2E spec (edit project dialog persistence). |
| packages/app/e2e/models/models-visibility.spec.ts | Deletes E2E spec (hide model removes from picker). |
| packages/app/e2e/models/model-picker.spec.ts | Deletes E2E spec (model picker selection). |
| packages/app/e2e/fixtures.ts | Deletes the full E2E fixture harness (backend + llm + project helpers). |
| packages/app/e2e/files/file-viewer.spec.ts | Deletes E2E specs (file viewer + cmd+f search). |
| packages/app/e2e/files/file-tree.spec.ts | Deletes E2E spec (file tree expand/open). |
| packages/app/e2e/files/file-open.spec.ts | Deletes E2E spec (open file via palette). |
| packages/app/e2e/commands/tab-close.spec.ts | Deletes E2E spec (mod+w closes tab). |
| packages/app/e2e/commands/panels.spec.ts | Deletes E2E spec (review panel keybind). |
| packages/app/e2e/commands/input-focus.spec.ts | Deletes E2E spec (ctrl+l focuses prompt). |
| packages/app/e2e/backend.ts | Deletes isolated E2E backend startup helper. |
| packages/app/e2e/app/titlebar-history.spec.ts | Deletes E2E specs (titlebar history navigation). |
| packages/app/e2e/app/session.spec.ts | Deletes E2E spec (open existing session + type). |
| packages/app/e2e/app/server-default.spec.ts | Deletes E2E spec (default server selection). |
| packages/app/e2e/app/palette.spec.ts | Deletes E2E specs (palette open/close). |
| packages/app/e2e/app/navigation.spec.ts | Deletes E2E spec (project route redirects). |
| packages/app/e2e/app/home.spec.ts | Deletes E2E specs (home rendering + server picker). |
| packages/app/e2e/AGENTS.md | Removes E2E testing guide content (file becomes empty). |
| bun.lock | Updates lockfile for Playwright dependency bump. |
Comments suppressed due to low confidence (1)
packages/app/e2e/AGENTS.md:1
- This file is now effectively empty. If the intent is to remove the E2E testing guide, it should be deleted; otherwise please leave a short note explaining where the guidance moved to (or why it was removed) to avoid a confusing empty doc file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+11
| import { test } from "@playwright/test" | ||
| test( | ||
| "test something cool", | ||
| { | ||
| annotation: { type: "todo" }, | ||
| }, | ||
| async () => { | ||
| test.fixme() | ||
| }, | ||
| ) |
There was a problem hiding this comment.
PR title says "delete all e2e tests", but this PR still adds/keeps an e2e test file (even though it immediately calls test.fixme()). Either remove the remaining test file(s) or adjust the PR title/description to reflect that e2e is being stubbed rather than fully deleted.
Comment on lines
276
to
284
| const tools: Interface["tools"] = Effect.fn("ToolRegistry.tools")(function* (input) { | ||
| const e2e = !!(yield* env.get("OPENCODE_E2E_LLM_URL")) | ||
| const filtered = (yield* all()).filter((tool) => { | ||
| if (tool.id === CodeSearchTool.id || tool.id === WebSearchTool.id) { | ||
| return input.providerID === ProviderID.opencode || Flag.OPENCODE_ENABLE_EXA | ||
| } | ||
| const usePatch = | ||
| e2e || | ||
| (input.modelID.includes("gpt-") && !input.modelID.includes("oss") && !input.modelID.includes("gpt-4")) | ||
| input.modelID.includes("gpt-") && !input.modelID.includes("oss") && !input.modelID.includes("gpt-4") | ||
| if (tool.id === ApplyPatchTool.id) return usePatch |
There was a problem hiding this comment.
This change removes the only consumer of Env.Service in this layer (the OPENCODE_E2E_LLM_URL check), so the earlier const env = yield* Env.Service binding is now unused and may trigger noUnusedLocals/lint failures. Consider removing the Env.Service dependency/binding entirely (or reintroduce a use if still needed).
Brendonovich
commented
Apr 14, 2026
Member
lgtm |
Uh oh!
There was an error while loading. Please reload this page.
cmaloney111 pushed a commit
to psi-oss/gpd-app
that referenced
this pull request
Apr 20, 2026
Cherry-picked from ea463e6
xywsxp pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
Cherry-picked from b6a6da06d86ed8f436bbc52f463df71a16a71dd6
6 tasks
nicko-ai added a commit
to VRSEN/agentswarm-cli
that referenced
this pull request
Apr 26, 2026
Follow upstream app e2e removal from anomalyco/opencode#22501 while keeping intentional Agent Swarm fork behavior.
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Cherry-picked from ea463e6
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Cherry-picked from ea463e6
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
Cherry-picked from 0e9f105577c379c068d46a75836d11d04079b047
isaacfinnegan pushed a commit
to isaacfinnegan/whispercode
that referenced
this pull request
Jun 15, 2026
Cherry-picked from ea463e6
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
Cherry-picked from ea463e604cdd2a3e83e1c286e39b789455f0d413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.