Skip to content

perf: speed up skill directory discovery - #22990

Merged
thdxr merged 1 commit into
devfrom
optimize-skill-dirs-loading
Apr 17, 2026
Merged

perf: speed up skill directory discovery#22990
thdxr merged 1 commit into
devfrom
optimize-skill-dirs-loading

Conversation

@thdxr

Copy link
Copy Markdown
Member

Summary

  • split skill initialization into a cheap discovery pass and a full parse pass so Skill.dirs() no longer loads every skill file
  • keep full skill parsing for get, all, and available so skill content and validation behavior stay unchanged
  • reduce startup work in code paths that only need skill directories for permissions and whitelisting

Verification

  • bun typecheck in packages/opencode from the main checkout
  • bun test test/skill/skill.test.ts test/tool/skill.test.ts in packages/opencode from the main checkout

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@thdxr
thdxr enabled auto-merge (squash) April 17, 2026 01:29
@thdxr
thdxr merged commit f137782 into devApr 17, 2026
@thdxr
thdxr deleted the optimize-skill-dirs-loading branch April 17, 2026 01:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@thdxr