Skip to content

fix(tui): route question replies through current workspace - #23844

Open
justinpbarnett wants to merge 14 commits into
anomalyco:devfrom
justinpbarnett:fix/question-workspace-routing-draft
Open

fix(tui): route question replies through current workspace#23844
justinpbarnett wants to merge 14 commits into
anomalyco:devfrom
justinpbarnett:fix/question-workspace-routing-draft

Conversation

@justinpbarnett

@justinpbarnettjustinpbarnett commented Apr 22, 2026

Copy link
Copy Markdown

Issue for this PR

Fixes#23843

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Passes the current TUI workspace when answering or rejecting QuestionPrompt requests.

This keeps question responses aligned with permission responses: POST requests need the explicit workspace query parameter for remote workspace routing.

How did you verify your code works?

  • bun typecheck from packages/opencode
  • git diff --check
  • SDK fetch-stub check: question.reply omits ?workspace=... unless workspace is passed explicitly
  • Fork push pre-push hook: bun turbo typecheck

Screenshots / recordings

N/A; routing-only TUI bug fix.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

rekram1-nodeand others added 13 commits April 22, 2026 00:35
@rekram1-node
feat: update codex plugin to support 5.5 (anomalyco#23789)
97f3c74
@Hona
chore: bump Bun to 1.3.13 (anomalyco#23791)
69e2f3b
@Brendonovich
fix(app): improve icon override handling in project edit dialog (anom…
a45d9a9
…alyco#23768)
@opencode-agent
chore: update nix node_modules hashes
ed3d364
@Hona
fix: preserve BOM in text tool round-trips (anomalyco#23797)
bb69648
@opencode-agent
chore: generate
bfb954e
@Hona
test: fix cross-spawn stderr race on Windows CI (anomalyco#23808)
0595c28
@opencode-agent
chore: generate
6aa475f
@Brendonovich
fix: consolidate project avatar source logic (anomalyco#23819)
88c5f6b
@justinpbarnett
Route TUI question answers through the active workspace
2e9332a
Remote workspace routing reads the workspace query parameter on POST requests, so question replies and rejects need to pass the current TUI workspace just like permission replies do.
Constraint: Server remote workspace routing depends on the workspace query parameter for POST requests
Rejected: Rely on experimental_workspaceID header alone | SDK only promotes that value to the query string for GET and HEAD
Confidence: high
Scope-risk: narrow
Directive: Keep question and permission response routing aligned when changing remote workspace behavior
Tested: bun typecheck in packages/opencode
Tested: git diff --check
Tested: SDK fetch-stub comparison showed POST question replies omit workspace query unless workspace is passed explicitly
Related: Fixesanomalyco#23843
@nexxeln
fix(tui): fail fast on invalid session startup (anomalyco#23837)
2a480a9
@opencode-agent
chore: generate
266e965
@justinpbarnett
Merge branch 'dev' into fix/question-workspace-routing-draft
faabc67
@muckelba

muckelba commented Apr 22, 2026

Copy link
Copy Markdown

Funny, i just opened up the same issue (#23878) and came to the same fix as you :D I can confirm adding the workspaceID works. I did it a little bit different tho: 5e56d66, but maybe your fix is enough.

@justinpbarnett
fix(tui): route question replies through current workspace
7caf00f
## Summary
- Merge current `dev` into the PR branch to clear stale conflicts.
- Keep question replies and rejections routed through the active TUI workspace.
- Preserve the branch's Codex model allowlist update.
## Testing
- `bun --cwd packages/opencode typecheck`
- `bun turbo typecheck` via the pre-push hook
@justinpbarnett
justinpbarnettforce-pushed the fix/question-workspace-routing-draft branch from d4c9b7e to 7caf00fCompareApril 24, 2026 19:14
@mastertykomastertyko mentioned this pull request May 19, 2026
Closed
@houz42

houz42 commented May 20, 2026•
edited
Loading

Copy link
Copy Markdown

Running this exact setup on opencode 1.15.4: headless server on Linux (systemd user service), TUI attached from macOS via SSH LocalForward. The question hang is reproducible in this configuration.

Setup:

  • opencode web --hostname 127.0.0.1 --port 4096 on Linux (systemd user service)
  • opencode attach http://localhost:4096 from macOS via ssh -L 4096:localhost:4096
  • Any agent that invokes the question tool (e.g. oh-my-openagent's orchestrator)

From reading the source:question/index.ts uses Deferred.await(deferred) with no timeout. The workspace-routing bug in QuestionPrompt looks like the same class of issue as the PermissionPrompt fix in #23593 — the POST request needs the ?workspace= query param to route to the right workspace, which this PR adds.

This affects the headless/remote-attach workflow which is a primary use case for running opencode on a dev box. The fix is small and the pattern is already established — would appreciate a review.

@MingyooLeeMingyooLee mentioned this pull request May 21, 2026
Closed
6 tasks
@github-actionsgithub-actionsBot mentioned this pull request Jun 3, 2026
Closed
6 tasks
@github-actionsgithub-actionsBot mentioned this pull request Jun 21, 2026
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamdotdevinadamdotdevinAwaiting requested review from adamdotdevin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question replies do not route to the active remote workspace

7 participants

@justinpbarnett@muckelba@houz42@rekram1-node@Hona@Brendonovich@nexxeln