Skip to content

fix(httpapi): preserve OpenAPI parameter parity - #25291

Merged
kitlangton merged 1 commit into
devfrom
kit/httpapi-parity-sweep
May 2, 2026
Merged

fix(httpapi): preserve OpenAPI parameter parity#25291
kitlangton merged 1 commit into
devfrom
kit/httpapi-parity-sweep

Conversation

@kitlangton

@kitlangtonkitlangton commented May 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve legacy OpenAPI parameter schemas for ID-like path/query params in the public HttpApi spec.
  • Tighten bridge coverage so route parameter schema drift is detected, not just parameter presence.
  • Add instance route guidance requiring legacy Hono and Effect HttpApi changes to stay behaviorally aligned.

Validation

  • bun typecheck
  • bun run test test/server/httpapi-bridge.test.ts test/server/httpapi-ui.test.ts
  • bun run test test/server/httpapi-json-parity.test.ts test/server/httpapi-session.test.ts test/server/httpapi-sync.test.ts test/server/httpapi-workspace.test.ts
  • OPENCODE_SDK_OPENAPI=httpapi ./packages/sdk/js/script/build.ts
  • Direct OpenAPI comparison: routes, params, statuses, content types, and request body shapes all match

Notes

  • Generated SDK files were inspected and restored; this PR only changes source, tests, and route guidance.

kitlangton
kitlangton commented May 1, 2026
View reviewed changes
Comment threadpackages/opencode/src/server/routes/instance/httpapi/public.ts
const PathParameterSchemas = {
sessionID: { type: "string", pattern: "^ses.*" },
messageID: { type: "string", pattern: "^msg.*" },
partID: { type: "string", pattern: "^prt.*" },

@kitlangtonkitlangtonMay 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is awful.

kitlangton
kitlangton commented May 1, 2026
View reviewed changes
Comment threadpackages/opencode/src/server/routes/instance/httpapi/public.ts
const PathParameterSchemas = {
sessionID: { type: "string", pattern: "^ses.*" },
messageID: { type: "string", pattern: "^msg.*" },
partID: { type: "string", pattern: "^prt.*" },

@kitlangtonkitlangtonMay 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

kitlangton
kitlangton commented May 1, 2026
View reviewed changes
Comment threadpackages/opencode/src/server/routes/instance/httpapi/public.ts
const override = QueryParameterSchemas[`${route} ${param.name}` as keyof typeof QueryParameterSchemas]
if (override) {
param.schema = override
if (!param.schema || typeof param.schema !== "object") return

@kitlangtonkitlangtonMay 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS CODE IS HOT GARBAGE. IN A GOOD WAY.

kitlangton
kitlangton commented May 1, 2026
View reviewed changes
Comment threadpackages/opencode/src/server/routes/instance/httpapi/public.ts
const override = QueryParameterSchemas[`${route} ${param.name}` as keyof typeof QueryParameterSchemas]
if (override) {
param.schema = override
if (!param.schema || typeof param.schema !== "object") return

@kitlangtonkitlangtonMay 1, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sike.

@kitlangton
kitlangton marked this pull request as draft May 1, 2026 20:47
@kitlangton
kitlangton marked this pull request as ready for review May 1, 2026 20:47
@kitlangton
kitlangton marked this pull request as draft May 1, 2026 20:47
@kitlangton
kitlangton marked this pull request as ready for review May 1, 2026 20:47
@kitlangton
kitlangton merged commit 0b498dd into devMay 2, 2026
17 checks passed
@kitlangton
kitlangton deleted the kit/httpapi-parity-sweep branch May 2, 2026 02:18
@Astro-HanAstro-Han mentioned this pull request May 6, 2026
Closed
66 tasks
oleksii-honchar pushed a commit to oleksii-honchar/better-opencode that referenced this pull request May 6, 2026
@kitlangton@oleksii-honchar
fix(httpapi): preserve OpenAPI parameter parity (anomalyco#25291)
0afd389
isaacfinnegan pushed a commit to isaacfinnegan/whispercode that referenced this pull request Jun 9, 2026
@kitlangton
fix(httpapi): preserve OpenAPI parameter parity (anomalyco#25291)
5f70ea8
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
@kitlangton
fix(httpapi): preserve OpenAPI parameter parity (anomalyco#25291)
24c3317
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
@kitlangton
fix(httpapi): preserve OpenAPI parameter parity (anomalyco#25291)
ad3e844
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
@kitlangton
fix(httpapi): preserve OpenAPI parameter parity (anomalyco#25291)
11a0ae3
isaacfinnegan pushed a commit to isaacfinnegan/whispercode that referenced this pull request Jun 15, 2026
@kitlangton
fix(httpapi): preserve OpenAPI parameter parity (anomalyco#25291)
e686b18
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
@kitlangton
fix(httpapi): preserve OpenAPI parameter parity (#25291)
3332461
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contributorVouched

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kitlangton