Uh oh!
There was an error while loading. Please reload this page.
refactor(desktop): use electron-log in shell-env and simplify env merging - #26284
Merged
Merged
Conversation
| mergeShellEnv(shell ? loadShellEnv(shell) : null, { | ||
| ...process.env, | ||
| OPENCODE_EXPERIMENTAL_ICON_DISCOVERY: "true", | ||
| OPENCODE_EXPERIMENTAL_FILEWATCHER: "true", |
There was a problem hiding this comment.
will this commit released soon?
I just upgraded my opencode desktop to the latest 1.14.41, and noticed that the PATH variable is not correct any more, missing /opt/homebrew/bin etc, which is initialized by ~/.zshrc. the missing path in $PATH makes the agent cannot access tool correctly, such as rg, gh etc.
I ask opencode to investigate related commit to cause the problem, and it leads to #25962 , which overwrite the probed shell env. I think this commit should fix the problem. It would be great to release the fix soon. thanks.
WJQSERVER pushed a commit
to WJQSERVER/opencode
that referenced
this pull request
May 8, 2026
katosun2 pushed a commit
to katosun2/opencode
that referenced
this pull request
May 10, 2026
imnpc
commented
May 13, 2026
v1.14.48 + macOS(intel) still wrong $ printenv PATH /usr/bin:/bin:/usr/sbin:/sbin |
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
isaacfinnegan pushed a commit
to isaacfinnegan/whispercode
that referenced
this pull request
Jun 15, 2026
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.log/console.warnusage inshell-env.tswithelectron-logvia a newgetLogger()export fromlogging.tsmergeShellEnvutility and simplifiespreferAppEnvinserver.tsto use plainObject.assigninstead