Uh oh!
There was an error while loading. Please reload this page.
fix(session): settle pending tool calls on schema errors - #30091
fix(session): settle pending tool calls on schema errors#30091codeg-dev wants to merge 2 commits into
Conversation
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Runtime smoke verified on private host with custom binary 1.15.13-empty-tool-validation: mock provider emitted malformed bash empty-object args; exported session local session shows the bash tool part settled as status error, not pending. |
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Additional v1.16.2 verification update:
This confirms the issue remains relevant on top of v1.16.2 and the patch still resolves the pending/running tool-call settlement path without changing the selected model. |
dd5c500 to
8ca3c99Comparecodeg-dev
commented
Jun 7, 2026
Rebased onto latest |
mikeatlas
commented
Jun 8, 2026
bump |
codeg-dev
commented
Jun 9, 2026
AI-assisted verification update (2026-06-09 KST): I cherry-picked this PR onto the current OpenCode Verified:
No regression observed in this local cross-platform smoke pass. |
8ca3c99 to
18f1324CompareAutomated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes#30093
Type of change
What does this PR do?
Settles a pending tool part to error when the stream later emits a matching schema-validation tool-error. This covers malformed built-in tool calls such as bash with an empty object, while preserving empty objects for tools that have no required args.
Prepared with AI assistance.
How did you verify your code works?
Focused tests are blocked in this worktree by an existing fixture issue: both the new processor test and unrelated test/provider/header-timeout.test.ts fail before assertions with ProviderModelNotFoundError for test/test-model.
Screenshots / recordings
Not a UI change.
Checklist