fix(app): keep desktop session tabs and selected-server sync consistent by Hona · Pull Request #30672 · anomalyco/opencode

Hona · 2026-06-04T03:51:21Z

Changelog

Fixed

Subagent routes now stay attached to their primary session desktop tab instead of opening separate tabs.
Deep-linked nested subagents now attach to the correct primary session tab after their parent sessions load.
Renaming a session updates its desktop tab title without requiring a reload.
Archiving a primary session while viewing one of its subagents now closes the correct desktop tab and navigates away safely.
Archive and delete actions immediately remove affected loaded sessions, cached data, and desktop tabs even while the live event stream is reconnecting.
Remote archive and delete events now remove affected desktop tabs and loaded session data consistently.
Closing an inactive desktop tab no longer switches away from the current tab, including while the New Session page is open.
Active and hovered tabs reserve room for the close button instead of covering the session title.
Numbered tab shortcuts such as Cmd+2 or Ctrl+2 now enable based on open desktop tabs instead of project count.
Provider and model settings for a selected server now read sync data from that selected server instead of the active app server.

Improved

Desktop tabs now model a primary session and its subagents as one navigational unit.
Loaded session trees share one traversal path for tab routing, cleanup, permission lookup, and request lookup.

Comparison

Alternative implementation of #30644 for side-by-side review.

Copilot

Pull request overview

This PR refactors desktop session tab handling to be rooted at the “root session” (so subagent/child routes stay attached to a single tab), centralizes lineage traversal into a reusable session graph, and introduces neutral “sessions unavailable” lifecycle events to coordinate archive/delete behavior across local and server-driven flows.

Changes:

Introduces src/session/tabs to model desktop tabs as root-session state with deterministic open/close/remove behavior.
Adds src/session/graph and rewires multiple call sites to use shared lineage/subtree traversal utilities.
Adds src/session/lifecycle + events for archive/delete propagation and updates global sync + UI wiring to publish/consume those events and track session_unavailable.

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/app/src/session/tabs/index.ts	Adds pure tab-state utilities keyed by root session and route-to-tab bindings.
packages/app/src/session/tabs/index.test.ts	Adds unit tests for root-tab binding, removals, and navigation effects.
packages/app/src/session/lifecycle/index.ts	Defines neutral session availability types for archive/delete.
packages/app/src/session/lifecycle/events.ts	Adds publish/read helpers for the new sessions-unavailable browser event.
packages/app/src/session/lifecycle/events.test.ts	Tests validation/parsing behavior for sessions-unavailable events.
packages/app/src/session/graph/index.ts	Introduces reusable lineage/root/subtree traversal helpers.
packages/app/src/session/graph/index.test.ts	Adds tests for root resolution, cycles, subtree collection, and path child selection.
packages/app/src/pages/session/message-timeline.tsx	Switches archive/delete behavior to subtree-aware eviction + sessions-unavailable publishing.
packages/app/src/pages/session/composer/session-request-tree.ts	Uses shared graph traversal for request selection within a subtree.
packages/app/src/pages/session.tsx	Updates import path for session prefetch module after re-org.
packages/app/src/pages/layout/helpers.ts	Uses shared graph traversal to find the child session on an active path.
packages/app/src/pages/layout.tsx	Makes archive behavior subtree-aware and publishes sessions-unavailable events.
packages/app/src/context/server-sync.tsx	Wires a sessions-unavailable hook into directory event handling.
packages/app/src/context/server-sync.test.ts	Updates imports after session infrastructure re-org.
packages/app/src/context/permission-auto-respond.ts	Uses shared graph traversal for ancestor checks when auto-accepting permissions.
packages/app/src/context/global-sync/types.ts	Adds `session_unavailable` state for archived/deleted tracking.
packages/app/src/context/global-sync/session/trim.ts	Fixes imports after moving session utilities under `session/`.
packages/app/src/context/global-sync/session/trim.test.ts	Updates test imports after module move.
packages/app/src/context/global-sync/session/store.ts	Adds `upsertSession` helper for stable binary-search insertion/update.
packages/app/src/context/global-sync/session/prefetch.ts	Moves/introduces session prefetch cache logic under `session/`.
packages/app/src/context/global-sync/session/prefetch.test.ts	Updates test imports after module move.
packages/app/src/context/global-sync/session/load.ts	Fixes types import path after moving session utilities under `session/`.
packages/app/src/context/global-sync/session/lineage.ts	Adds lineage hydration helper that loads missing ancestors while respecting unavailability.
packages/app/src/context/global-sync/session/lineage.test.ts	Tests lineage hydration behavior (resolved, unavailable, cycle).
packages/app/src/context/global-sync/session/cache.ts	Moves/introduces session cache drop + eviction selection under `session/`.
packages/app/src/context/global-sync/session/cache.test.ts	Updates test imports after module move.
packages/app/src/context/global-sync/event-reducer.ts	Adds `session_unavailable` tracking and publishes subtree-unavailable changes.
packages/app/src/context/global-sync/event-reducer.test.ts	Extends tests for subtree unavailability + idempotent archive transitions.
packages/app/src/context/global-sync/child-store.ts	Initializes `session_unavailable` in per-directory store state.
packages/app/src/context/global-sync/bootstrap.test.ts	Updates bootstrap state to include `session_unavailable`.
packages/app/src/context/directory-sync.ts	Adds lineage hydration during sync, blocks re-inserting unavailable/archived sessions, and uses `upsertSession`.
packages/app/src/components/titlebar.tsx	Replaces ad-hoc tab store with `session/tabs` + listens for sessions-unavailable events.
packages/app/src/components/titlebar-session-events.ts	Removes deprecated session-tabs-removed event mechanism.
packages/app/src/components/titlebar-session-events.test.ts	Removes tests for deprecated session-tabs-removed event mechanism.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+ if (!tracked(directory, sessionID)) return
+ const data = response?.data
+ if (!data) return
+ if (data.time.archived || store.session_unavailable[ancestorID]) return data


@@ -135,10 +140,12 @@ export function applyDirectoryEvent(input: {
 )
 }
 cleanupSessionCaches(input.setStore, info.id, input.setSessionTodo)


@@ -162,6 +171,7 @@ export function applyDirectoryEvent(input: {
 )
 }
 cleanupSessionCaches(input.setStore, info.id, input.setSessionTodo)


 input.setStore("sessionTotal", (value) => Math.max(0, value - 1))
 break
 }
+ input.setStore("session_unavailable", info.id, undefined)


Copilot

Pull request overview

Copilot reviewed 35 out of 37 changed files in this pull request and generated 4 comments.

+export function loadedSessionTreeIDs(sessions: SessionNode[], rootID: string) {
+ const ids = new Set([rootID])
+ const queue = [rootID]
+
+ for (const id of queue) {
+ for (const session of sessions) {
+ if (session.parentID !== id || ids.has(session.id)) continue
+ ids.add(session.id)
+ queue.push(session.id)
+ }
+ }
+
+ return ids
+}


@@ -881,6 +878,7 @@ export function MessageTimeline(props: {
 const sessions = (sync.data.session ?? []).filter((s) => !s.parentID && !s.time?.archived)


 expect(store.session_status.ses_1).toBeUndefined()
 })

+ test("reports loaded routes but only marks the archived session unavailable", () => {


 <div class="flex min-w-0 flex-1 flex-row items-center gap-1.5 overflow-hidden">
 <div class="flex min-w-0 flex-row items-center gap-1.5 overflow-hidden">
- <For each={tabsEnriched()}>
+ <For each={tabsEnriched().map((resolve) => resolve())}>


github-actions · 2026-07-04T22:21:12Z

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

The PR was created more than 1 month ago
The PR had fewer than 2 positive reactions
Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

fix(app): model desktop session tabs as root sessions
14b7cf3

CopilotAI review requested due to automatic review settings June 4, 2026 03:51

Hona requested a review from adamdotdevin as a code owner June 4, 2026 03:51

Copilotstarted reviewing on behalf of Hona June 4, 2026 03:51 View session

CopilotAI reviewed Jun 4, 2026
View reviewed changes

Hona added 4 commits June 4, 2026 13:59

refactor(app): simplify session tree terminology
8d8545d

refactor(app): simplify desktop session tabs
cc07c49

fix(app): invalidate tabs after local session removal
a4c7d26

fix(app): remove sessions after local archive or delete
8f59b8d

Hona requested a review from Copilot June 4, 2026 06:11

Copilotstarted reviewing on behalf of Hona June 4, 2026 06:11 View session

CopilotAI reviewed Jun 4, 2026
View reviewed changes

Hona added 2 commits June 4, 2026 16:55

fix(app): address desktop tab review issues
aef5f3f

refactor(app): centralize session removal cleanup
d4c6a3a

Hona changed the title ~~fix(app): model desktop session tabs as root sessions~~fix(app): keep desktop session tabs consistent across subagents and removalsJun 4, 2026

fix(app): ignore stale session events after removal
10fd9d6

Hona changed the title ~~fix(app): keep desktop session tabs consistent across subagents and removals~~fix(app): keep desktop session tabs and selected-server sync consistentJun 4, 2026

fix(app): harden session removal reconciliation
9a6b391

thdxr requested a review from Brendonovich as a code owner June 11, 2026 00:17

This was referenced Jun 24, 2026
fix(app): clear followup queue on session revert, add remove button to queued messages #33625
Closed
feat(desktop): preserve session model selection #34612
Closed

github-actionsBot closed this Jul 4, 2026

github-actionsBot added the automated-pr-cleanup label Jul 4, 2026

Navigation Menu

Uh oh!

fix(app): keep desktop session tabs and selected-server sync consistent - #30672

fix(app): keep desktop session tabs and selected-server sync consistent#30672
Hona wants to merge 9 commits into
anomalyco:devfrom
Hona:fix/desktop-session-tabs-ddd

Hona commented Jun 4, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

CopilotAI left a comment

Uh oh!

github-actionsBot commented Jul 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -881,6 +878,7 @@ export function MessageTimeline(props: {
		const sessions = (sync.data.session ?? []).filter((s) => !s.parentID && !s.time?.archived)

Uh oh!

Conversation

Hona commented Jun 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Fixed

Improved

Comparison

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actionsBot commented Jul 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Hona commented Jun 4, 2026•
edited
Loading