Uh oh!
There was an error while loading. Please reload this page.
fix(tui): load root sessions safely in dialogs - #31132
Closed
CasualDeveloper wants to merge 1 commit into
Closed
Conversation
Contributor
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found a related PR: PR #26432:
The current PR (#31132) represents an improved/updated fix that builds upon the earlier approach in #26432. |
This was referenced Jun 6, 2026
CasualDeveloper
marked this pull request as draft
June 6, 2026 21:26
CasualDeveloperforce-pushed
the
fix/16270-tui-root-session-dialog-loading
branch
from
June 6, 2026 21:50
72d361b to
bdcc5baCompareCasualDeveloper
marked this pull request as ready for review
June 6, 2026 21:51
antomicblitz
commented
Jun 7, 2026
Yes please 👍 |
This was referenced Jun 7, 2026
CasualDeveloperforce-pushed
the
fix/16270-tui-root-session-dialog-loading
branch
2 times, most recently
from
June 14, 2026 17:46
c162859 to
14b3b8dCompareantomicblitz
commented
Jun 14, 2026
Cmon guys this is such a simple fix. Just merge it |
CasualDeveloperforce-pushed
the
fix/16270-tui-root-session-dialog-loading
branch
2 times, most recently
from
June 16, 2026 11:26
5a0c48a to
3a73283Compare
This was referenced Jun 16, 2026
CasualDeveloperforce-pushed
the
fix/16270-tui-root-session-dialog-loading
branch
2 times, most recently
from
June 19, 2026 21:00
31bd14d to
460e883CompareProblem: Session dialogs built options from mixed or not-yet-loaded session data, which let child sessions crowd out roots and could freeze or stall an empty browse order during startup.\n\nSolution: Query root sessions from dialog-local resources, keep the selector mounted while browse loads, and use parent-owned filtering so search narrows immediately while debounced server search augments off-page matches.\n\nNotes: Refs anomalyco#16270 and anomalyco#31125.
CasualDeveloperforce-pushed
the
fix/16270-tui-root-session-dialog-loading
branch
from
June 23, 2026 15:03
460e883 to
5c7acd5CompareContributorAuthor
Closing this as superseded by #33931, which landed the session switcher root-session loading fix on dev and closed #16270. and thank you @antomicblitz for the upvote! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#16270
Closes#31125
Partially addresses #13877
Supersedes #23276, #24383, #26432
Type of change
What does this PR do?
Problem: Session dialogs built options from mixed or not-yet-loaded session data, which let child sessions crowd out roots and could freeze an empty browse order during startup.
Solution:
How did you verify your code works?
bun test test/cli/tui/dialog-session-list.test.tsbun turbo typecheckScreenshots / recordings
N/A. This changes session query/loading behavior, not the rendered layout.
Notes
Checklist