Uh oh!
There was an error while loading. Please reload this page.
fix(tui): replace @solid-primitives/scheduled with manual debounce for Node.js compatibility - #31199
fix(tui): replace @solid-primitives/scheduled with manual debounce for Node.js compatibility#31199malventano wants to merge 1 commit into
Conversation
…r Node.js compatibility @solid-primitives/scheduled returns a no-op when isServer=true. The conditions: ["node"] build change (commit 1e216e1, #30873) resolves solid-js/web to server.js, setting isServer=true. This breaks: - Session search in /sessions dialog (both basic list and experimental switcher) - search input does not filter results - Session switcher preview pane - preview freezes after first hover Replace @solid-primitives/scheduled with manual setTimeout: - signal.ts - createDebouncedSignal → manual trailing-edge debounce - preview-pane.tsx - createLeadingTrailingSignal → manual leading + trailing edge No build condition changes. No skipFilter changes. Fix isolated to two utility files.
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The following comment was made by an LLM, it may be inaccurate: Related PR FoundPR #31185: fix(tui): enable client-side filtering for session search dialogs Relationship: According to the current PR description, #31185 is a "superseded skipFilter workaround" that is being replaced by this approach. The current PR (31199) takes a different solution path by replacing Both PRs address the same issue (#31182) where session search filtering is broken due to the Node.js compatibility problem introduced by the build condition changes in PR #30873. |
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
@solid-primitives/scheduled returns a no-op when
isServer=true. Theconditions: ["node"]build change (commit 1e216e1, #30873) resolvessolid-js/webtoserver.js, settingisServer=true. This breaks:/sessionsdialog (both basic list and experimental switcher) — search input does not filter resultsSolution
Replace
@solid-primitives/scheduledwith manualsetTimeout:signal.ts—createDebouncedSignal→ manual trailing-edge debouncepreview-pane.tsx—createLeadingTrailingSignal→ manual leading + trailing edgeNo build condition changes. No
skipFilterchanges. Fix isolated to two utility files.Tradeoffs
clear()method and automaticonCleanup(neither currently used)Closes#31182
Supersedes #31185