Skip to content

fix: compaction context loss, prune re-attach, overflow threshold, missing config key - #31891

Closed
LifetimeVip wants to merge 4 commits into
anomalyco:devfrom
LifetimeVip:fix/compaction-context
Closed

fix: compaction context loss, prune re-attach, overflow threshold, missing config key#31891
LifetimeVip wants to merge 4 commits into
anomalyco:devfrom
LifetimeVip:fix/compaction-context

Conversation

@LifetimeVip

@LifetimeVipLifetimeVip commented Jun 11, 2026•
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes#30805#30806#30807#30811#31764#31769

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fix compaction context loss, prune re-attach causing AGENTS.md re-load, overflow threshold calculation bypass, and missing compaction config key in isV1() detection.

How did you verify your code works?

Tested in custom fork with 65 commits on top of v1.17.3, running in daily production use.

Screenshots / recordings

N/A - logic change, not UI

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

LifetimeVip added 4 commits June 11, 2026 06:14
fix:#30806#30807#30811- compaction issues causing context loss
fe36fc7
#30806 - move Started event after LLM success to prevent dangling events
#30807 - increase DEFAULT_KEEP_TOKENS to 16K preserving more read results
#30811 - increase TOOL_OUTPUT_MAX_CHARS to 8K keeping more file content
fix: compaction preserves file read content, destructive command filter
70535f4
fix: instruction.ts compaction forgets loaded AGENTS.md - remove comp…
c51b8fe
…acted skip
fix: isV1 config detection missing compaction key - preserve_recent_t…
c8618f2
…okens silently dropped
@github-actionsgithub-actionsBot added the needs:compliance This means the issue will auto-close after 2 hours. label Jun 11, 2026
@github-actions

github-actionsBot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Found a related PR:

PR #30979: "fix: prune and instruction re-attachment bugs (#30807)"

This PR appears to address similar issues related to prune and instruction re-attachment bugs (specifically issue #30807, which is also listed in the current PR's fixes). It may be addressing overlapping concerns with the prune loop and re-attach logic.

@github-actionsgithub-actionsBot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jun 11, 2026
@github-actions

github-actionsBot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@LifetimeVip

LifetimeVip commented Jun 11, 2026

Copy link
Copy Markdown
Author

@thdxr@jlongster@rekram1-node@simonklee@Hona these 8 PRs together fix 30 open issues (compaction context loss, Windows encoding, tool error handling, security, etc.). All are mergeable with no conflicts. Would appreciate a review when you have time.

@winstern1998-commitswinstern1998-commits mentioned this pull request Jul 25, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Compaction overflow threshold too low when limit.input is set; compaction LLM overflow causes retry loop

2 participants

@LifetimeVip@simonklee