fix(app): refresh v2 tab titles on session title change

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.

[RonnyPfannschmidt]

Issue for this PR

Closes#30329

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

In the v2 layout, the tab bar does not refresh when the LLM generates a session title. The createEffect in TabNavItem that updates titleEl.textContent reads props.session()?.title — but session() is a createResource that performs an async fetch and does not track reactive store updates from SSE session.updated events.

This change passes sessionData (the reactive sync.session.data.info record) and sessionId through to TabNavItem. The effect reads from sessionData?.[sessionId] first, which properly tracks reactive dependencies on the store. When a title update arrives via SSE → session.remember(), the store record updates and the effect fires.

How did you verify your code works?

• bun test src/context/server-session.test.ts from packages/app: 5 pass (including new test for title update propagation)
• bun typecheck from packages/app: no new errors
• Manual verification: v2 tab bar now refreshes title when LLM generates session title

Screenshots / recordings

_Not applicable — this is a reactive update fix, not a visual change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Related PR Found

PR #30335: fix(app): refresh v2 tab titles
#30335

This PR appears to address the same issue of refreshing v2 tab titles. Since your current PR (PR #33836) is specifically about refreshing tab titles on session title changes, you should verify whether PR #30335 already resolves the issue or if there's a different root cause being addressed.

Recommendation: Check if PR #30335 was closed/merged and why the issue (#30329) still required a fix. If it was an incomplete solution, your PR may be building on or replacing that approach.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

[RonnyPfannschmidt]

⚠️Process not complete — this PR is a draft while I verify the fix against the upstream codebase. The local architecture differs from what the original issue (#30329) and competing PR (#30335) describe, so this takes a different (simpler) approach. Will ready for review once verification is complete.