fix: preserve attachment file paths

[jparradog]

Issue for this PR

Closes#23801
Closes#17488

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

Preserves attachment source paths as metadata while keeping prompt request payloads portable across local, HTTP, WSL, SSH, and remote server connections.

• Sends source-backed attachments using their captured data: URL as the request content.
• Preserves the original filesystem path only as FilePartInput.source metadata.
• Applies the same behavior to normal prompts, queued/follow-up slash commands, and direct slash commands.
• Materializes raw desktop clipboard images into restrictive temp PNG files so source metadata is available when possible, while retaining data-only fallback behavior.

How did you verify your code works?

Fresh verification at PR head 5423d2b971bab6c79f67216553c3a086af5acd3d:

• bun test --preload ./happydom.ts ./src/components/prompt-input/build-request-parts.test.ts ./src/components/prompt-input/submit.test.ts ./src/components/prompt-input/attachments.test.ts from packages/app: 32 pass, 0 fail.
• bun typecheck from packages/app: pass.
• bun typecheck from packages/desktop: pass.
• git diff --check: pass.
• Confirmed request URLs use dataUrl, while sourcePath is preserved only as FilePartInput.source metadata.

Screenshots / recordings

N/A — no visible UI change; attachment preview behavior is preserved.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

I found a potentially related PR:

feat: save file attachments to disk before model processing (#30153)

• This PR addresses similar functionality around attachment file handling and model processing, which relates to the current PR's goal of preserving filesystem paths for attachments so agents can access files.

The current PR (34234) is the only exact match for "preserve attachment file paths", and the search for similar concerns reveals that #30153 handles a related but potentially different approach to file attachments (saving to disk vs. preserving paths).

These could be addressing the same underlying issue or complementary aspects of attachment handling. You may want to review #30153 to ensure there's no overlap in the implementation approach.

[github-actions]

Thanks for updating your PR! It now meets our contributing guidelines. 👍

[andrei-hasna]

Merge queue review: not merging this yet.

Validation that passed locally on a clean temp worktree based on current dev:

• git merge --no-ff --no-commit origin/pr-34234 applied cleanly.
• bun install --frozen-lockfile passed.
• bun test --preload ./happydom.ts ./src/components/prompt-input/attachments.test.ts ./src/components/prompt-input/build-request-parts.test.ts ./src/components/prompt-input/submit.test.ts passed: 32 pass, 0 fail.
• bun run typecheck passed in packages/app and packages/desktop.
• bun run lint exited 0; it reports existing warnings but no errors.

Blockers before merge:

• The active dev ruleset requires unit (linux), unit (windows), e2e (linux), e2e (windows), and typecheck. This PR currently only has the pr-standards checks (check-compliance, check-standards), so GitHub reports mergeStateStatus=BLOCKED.
• attachmentRequestUrl now sends any sourcePath as a file:// URL, but the app supports non-local WSL/SSH/HTTP server connections. For those sessions, the server will read that path on the server filesystem, not the desktop filesystem. Please gate path-backed URLs to truly local sidecar sessions and keep data:/uploaded bytes for remote/WSL/SSH.
• The request can diverge from what the user previewed: the UI captures a dataUrl, but the model request prefers the live path. If the source file changes, is deleted/replaced, or the prompt is replayed from history, the model may receive different bytes than the preview. Please bind path-backed requests to the captured bytes or validate that the path still represents the same attachment before use.
• Clipboard PNGs are materialized under OS temp and cleaned only on will-quit with best-effort rm. Please add lifecycle cleanup or another bounded retention strategy for pasted screenshots.
• Windows UNC/network paths are not covered. encodeFilePath handles drive-letter paths, but \\server\share\file needs explicit file URL handling/tests.

[andrei-hasna]

Merge queue recheck: not merging this PR yet.

Validated locally on a clean temp worktree based on current origin/dev (61a7f6db3):

• PR head 049c41886020b3f8385339863905ac002b3e160d merges cleanly with git merge --no-ff --no-commit origin/pr/34234-head.
• bun install --frozen-lockfile passed.
• bun test --preload ./happydom.ts ./src/components/prompt-input/attachments.test.ts ./src/components/prompt-input/build-request-parts.test.ts ./src/components/prompt-input/submit.test.ts passed: 32 pass, 0 fail.
• bun run typecheck passed in packages/app and packages/desktop.
• bun run lint exited 0 with existing warnings only.

Blockers before merge:

• GitHub still reports mergeStateStatus=BLOCKED. The active dev ruleset requires unit (linux), unit (windows), e2e (linux), e2e (windows), and typecheck, but this PR currently only shows pr-standards checks.
• The PR branch is stale: 33 commits behind current origin/dev and 2 ahead. It merges cleanly locally, but required CI/review should run against the updated base.
• attachmentRequestUrl sends every sourcePath as a server-side file:// URL (packages/app/src/components/prompt-input/build-request-parts.ts:55-56; slash command paths at packages/app/src/components/prompt-input/submit.ts:91-96 and :474-479). Server handling reads that URL from the server filesystem (packages/opencode/src/session/prompt.ts:808-811), which is unsafe for WSL/remote/HTTP sessions where the desktop path may not exist on the server.
• The optimistic preview uses captured dataUrl bytes, but the actual request can read from the live file path (packages/app/src/components/prompt-input/build-request-parts.ts:188-214). If the file changes, is deleted, or is replaced before send/replay, the model can receive different bytes than the user previewed or fail to read.
• Clipboard PNGs are materialized under OS temp and cleaned only on will-quit (packages/desktop/src/main/ipc.ts:23-25, :50-52, :187-198). Please add bounded lifecycle cleanup/retention.
• UNC/network paths are not covered by tests; encodeFilePath is drive-letter aware, but \\server\share\file needs explicit handling/coverage.

An independent adversarial verifier also recommended not merging for the same blockers.

[andrei-hasna]

Merge queue recheck: not merging this PR yet.

Current GitHub state:

• Head 049c41886020b3f8385339863905ac002b3e160d; current origin/dev is dfeb1b5051a05b359bd4af711b204d2c0342c5f4.
• Branch freshness: 34 commits behind current origin/dev, 2 commits ahead.
• GitHub reports mergeable=MERGEABLE, but mergeStateStatus=BLOCKED.
• Visible check rollup only has pr-standards (check-compliance, check-standards) passing; combined commit status is still pending.
• No latest reviews / reviewDecision is empty.

Fresh local validation on a clean temp worktree based on current origin/dev:

• git merge --no-ff --no-commit origin/pr/34234-head applied cleanly.
• bun install --frozen-lockfile passed.
• bun test --preload ./happydom.ts ./src/components/prompt-input/attachments.test.ts ./src/components/prompt-input/build-request-parts.test.ts ./src/components/prompt-input/submit.test.ts passed: 32 pass, 0 fail.
• bun run typecheck passed in packages/app and packages/desktop.
• bun run lint exited 0 with existing warnings only.

Blockers before merge:

• The PR is still blocked by repository merge policy: GitHub reports mergeStateStatus=BLOCKED, and only the two pr-standards checks are present on the PR head.
• attachmentRequestUrl sends every sourcePath as file://... (packages/app/src/components/prompt-input/build-request-parts.ts:55-56; slash commands at packages/app/src/components/prompt-input/submit.ts:91-96 and :474-479). The server consumes file: URLs by resolving and reading paths on the server filesystem (packages/opencode/src/session/prompt.ts:808-854). The app supports non-local HTTP, WSL sidecar, and SSH server connections (packages/app/src/context/server.tsx:156-188), so desktop paths can be wrong or unreadable for remote/WSL/SSH sessions. Please gate path-backed URLs to truly local sidecar sessions or keep using captured bytes for non-local sessions.
• The actual request can diverge from the user preview: request parts use the live sourcePath, while optimistic parts use the captured dataUrl (packages/app/src/components/prompt-input/build-request-parts.ts:188-214). If the source file changes, is deleted/replaced, or the prompt is replayed, the model may receive different bytes than the preview.
• Clipboard PNGs are materialized under an app temp directory and only cleaned on will-quit (packages/desktop/src/main/ipc.ts:23-25, :50-52, :187-198). Please add bounded lifecycle cleanup or retention so crashes/long-running sessions do not accumulate unbounded temp files.
• UNC/network path behavior is still not covered. encodeFilePath normalizes backslashes and has drive-letter handling, but no explicit UNC branch or round-trip tests (packages/app/src/context/file/path.ts:83-101). Please add coverage for \\server\share\file.

The previous independent adversarial verifier comment applies to the same PR head and recommended not merging for these same blockers.

[andrei-hasna]

Merge queue recheck: not merging this PR.

Current GitHub state:

• Head 049c41886020b3f8385339863905ac002b3e160d; current live dev is 6ee817d0416cc902bdf1e05b0a3db1e94d07434a.
• Compare status is diverged: 2 commits ahead, 35 commits behind dev.
• PR is open and not draft. GitHub reports mergeable=MERGEABLE, but mergeStateStatus=BLOCKED / mergeable_state=blocked.
• Visible checks on the PR head are only check-compliance and check-standards, both passing.
• No PR reviews are present; reviewers are still requested.

Local validation in an isolated worktree based on current origin/dev:

• git merge --no-commit --no-ff origin/pr/34234 applied cleanly.
• bun test --preload ./happydom.ts ./src/components/prompt-input/attachments.test.ts ./src/components/prompt-input/build-request-parts.test.ts ./src/components/prompt-input/submit.test.ts from packages/app: 32 pass, 0 fail.
• bun typecheck from packages/app: pass.
• bun typecheck from packages/desktop: pass.
• git diff --check: pass.

Blockers before merge:

• Repository policy still blocks the PR: GitHub reports mergeStateStatus=BLOCKED, no review decision, and only the standards checks are visible on the PR head.
• High: restored clipboard attachments can keep stale temp sourcePaths. attachmentRequestUrl always prefers sourcePath over dataUrl (packages/app/src/components/prompt-input/build-request-parts.ts:55-56), while desktop clipboard images are materialized under an app temp directory (packages/desktop/src/main/ipc.ts:23-25, :187-198) that is removed on quit (packages/desktop/src/main/ipc.ts:50-52). The renderer stores that path on the file (packages/desktop/src/renderer/index.tsx:268-276), and prompt/history state can persist image parts (packages/app/src/context/prompt.tsx:197-203, packages/app/src/components/prompt-input/history.ts:93-96). After restart or history/draft restore, submission can send file://...opencode-clipboard-attachments... for a deleted temp file instead of the retained dataUrl. Please avoid persisting ephemeral clipboard paths, ignore them after restore, or validate/fallback to dataUrl before submission.
• Previously reported blockers still appear unresolved in this PR head: path-backed file:// URLs are not gated to truly local sidecar sessions; request bytes can diverge from the preview if the source file changes; clipboard temp cleanup has no bounded retention beyond best-effort quit cleanup; UNC/network paths still need explicit handling/tests.

Independent adversarial verification also recommended not merging for the stale restored-clipboard-path blocker.

[andrei-hasna]

Merge queue recheck: not merging this PR.

Current GitHub state:

• Head is still 049c41886020b3f8385339863905ac002b3e160d; current live dev is b7e4f1ef7433f83ba009eefa2997aeb81017f6ed.
• Compare status is diverged: 2 commits ahead and 269 commits behind dev.
• GitHub reports mergeable=MERGEABLE, but mergeStateStatus=BLOCKED.
• Visible PR checks are only check-compliance and check-standards, both passing; combined commit status is pending.
• No latest reviews / empty review decision; review requests are still open for Hona and Brendonovich.
• Local merge-tree check against current origin/dev produced a tree successfully, so I did not find a file-conflict blocker.

Validation/evidence from this recheck:

• git fetch origin dev pull/34234/head:refs/remotes/origin/pr/34234 --prune refreshed refs.
• git rev-list --left-right --count origin/dev...origin/pr/34234 returned 269 2.
• git merge-tree --write-tree origin/dev origin/pr/34234 succeeded.
• git diff --check origin/dev...origin/pr/34234 passed.
• Independent adversarial review also recommended do not merge.

Blockers before merge:

• Repository policy/GitHub state still blocks the PR: mergeStateStatus=BLOCKED, combined status pending, and no review decision.
• The branch is very stale and should be updated so required CI/review run against current dev.
• The core behavioral blockers remain in this unchanged head: attachmentRequestUrl always prefers sourcePath and sends it as file://... (packages/app/src/components/prompt-input/build-request-parts.ts:55-56; slash-command paths in submit.ts), while server handling reads file: URLs on the server filesystem (packages/opencode/src/session/prompt.ts:844-854). This is still unsafe for HTTP, WSL sidecar, and SSH server connections where the desktop path may not exist on the server.
• Request bytes can still diverge from the preview: request parts use the live path-backed URL while optimistic parts use the captured dataUrl (build-request-parts.ts:188-214).
• Clipboard temp-path lifecycle remains risky: pasted images are materialized under temp and cleaned only on best-effort will-quit, while the renderer stores that path as the attachment source path. Restored/history submissions can retain a stale temp path instead of falling back to retained bytes.

[jparradog]

Follow-up after the merge queue review:

The blocker around source-backed attachments sending desktop file:// paths has been addressed in 5423d2b971bab6c79f67216553c3a086af5acd3d.

Current behavior:

• request content uses the captured data: URL;
• original filesystem paths are preserved only as FilePartInput.source metadata;
• normal prompts, queued/follow-up slash commands, and direct slash commands use the same request/source helpers.

Fresh verification on the current PR head:

• packages/app: prompt-input tests passed — 32 pass, 0 fail;
• packages/app: bun typecheck passed;
• packages/desktop: bun typecheck passed;
• git diff --check passed.

GitHub currently reports the PR as mergeable and the visible check-standards / check-compliance checks are passing.

[github-actions]

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.