Uh oh!
There was an error while loading. Please reload this page.
fix: preserve Bedrock DeepSeek model ids - #34441
Conversation
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #18948: fix(provider): prevent Bedrock from prefixing ARN and deepseek.v3.2 model IDs This appears to be directly related to the current PR #34441. Both PRs address the same issue of preserving Bedrock DeepSeek model IDs (preventing prefixing/normalization that shouldn't happen). You should check if PR #18948 was previously closed or if this is addressing a regression or incomplete fix. |
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
YeEmrick
commented
Jun 29, 2026
Updated after rechecking the Bedrock DeepSeek R1 profile behavior. This PR now preserves the intended split:
This is related to #18948, but this PR also covers the current Verified locally:
Known unrelated local blockers while testing broader gates:
|
Robin1987China
left a comment
There was a problem hiding this comment.
LGTM. The narrowing from "deepseek" to "deepseek.r1" correctly distinguishes cross-region inference profiles (R1) from on-demand models (V3.2). The arn: guard is a solid defensive addition — foundation-model ARNs should never be region-prefixed.
One non-blocking note: if Bedrock adds DeepSeek R2 models that also require cross-region profiles, the requiresPrefix list will need updating. The narrow match is the safer choice for now.
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
marc-jan
commented
Aug 1, 2026
Can this be re-opened and merged? It was already reviewed, but now closed. It is still a problem if you are stuck with AWS and need to use bedrock. |
Issue for this PR
Closes#34412
Related #18812
Type of change
What does this PR do?
Bedrock DeepSeek model IDs were being treated like generic cross-region model IDs. That changed
deepseek.v3.2intous.deepseek.v3.2, which Bedrock rejects for the on-demand model.This PR keeps explicit Bedrock model identifiers intact:
deepseek.v3.2staysdeepseek.v3.2arn:aws:bedrock:...:foundation-model/...stays unchangedus.deepseek.r1-v1:0still pass through unchangedHow did you verify your code works?
Tested:
cd packages/opencode && bun test test/provider/amazon-bedrock.test.tscd packages/core && bun typecheckgit diff --checkReviewer can confirm by configuring
amazon-bedrock/deepseek.v3.2and checking that the provider receivesdeepseek.v3.2, notus.deepseek.v3.2.Local note:
cd packages/core && bun test test/plugin/provider-amazon-bedrock.test.tscurrently fails before this PR assertions withCannot access 'AmazonBedrockPlugin' before initialization.Screenshots / recordings
N/A, provider behavior only.
Checklist
If you do not follow this template your PR will be automatically rejected.