Uh oh!
There was an error while loading. Please reload this page.
fix(app): clamp virtualizer range to scroll bounds - #34588
Merged
Conversation
opencode-agentBotforce-pushed
the
session-virtualizer-repro
branch
from
June 30, 2026 09:31
8d08dc1 to
3b57810Compareopencode-agentBotforce-pushed
the
session-virtualizer-repro
branch
from
July 1, 2026 01:12
3b57810 to
af7b6d8CompareHona
marked this pull request as ready for review
July 1, 2026 01:14
Hona
enabled auto-merge (squash)
July 1, 2026 01:14
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s @tanstack/virtual-core patch to clamp the scroll offset used for virtual range calculation to the actual scrollable bounds, preventing invalid “end-of-list” ranges when initialOffset is extremely large but the browser clamps scrollTop to 0.
Changes:
- Clamp
scrollOffsetto0...max(totalSize - viewportSize, 0)before callingcalculateRange. - Apply the change consistently across the patched package’s
srcand builtdistoutputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+60
| diff --git a/dist/cjs/index.cjs b/dist/cjs/index.cjs | ||
| @@ -716,10 +716,12 @@ |
Comment on lines
+74
to
+75
| diff --git a/dist/esm/index.js b/dist/esm/index.js | ||
| @@ -714,10 +714,12 @@ |
Comment on lines
+89
to
+90
| diff --git a/src/index.ts b/src/index.ts | ||
| @@ -1336,12 +1336,14 @@ |
Hona
disabled auto-merge
July 1, 2026 01:21
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
opencode-agentBotforce-pushed
the
session-virtualizer-repro
branch
from
July 1, 2026 01:25
af7b6d8 to
1759967CompareUh oh!
There was an error while loading. Please reload this page.
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 20, 2026
Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
3kaiu pushed a commit
to 3kaiu/opencode-x
that referenced
this pull request
Jul 31, 2026
Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
banlanzs pushed a commit
to banlanzs/opencode
that referenced
this pull request
Aug 6, 2026
Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
charlesverge pushed a commit
to charlesverge/opencode
that referenced
this pull request
Aug 11, 2026
Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tanstack/virtual-corepatch instead of special-casing the session timeline.0...max(totalSize - viewportSize, 0)).initialOffset: Number.MAX_SAFE_INTEGERfrom producing an impossible end-of-list range when the browser has clamped a fit-to-viewport list toscrollTop = 0.Validation
bun install --frozen-lockfilebun typecheckfrompackages/appRepro evidence