fix: normalize Windows paths in session directory SQL queries

[VoidPurifier]

What does this PR do?

Fixes path separator mismatch on Windows where SessionTable.directory stores paths in POSIX format (D:/Workspace) but query parameters arrive with backslashes (D:\Workspace), causing SQLite exact-match to fail and session lists to appear empty.

Added dbDir() normalization (\\ -> / on win32 only) to all 5 eq(SessionTable.directory, ...) call sites across 3 files:

• packages/core/src/session.ts — V2Session.list
• packages/opencode/src/session/session.ts — listGlobal, listByProject (2x)
• packages/opencode/src/project/project.ts — project migration query

Type of change

• Bug fix (non-breaking change which fixes an issue)

How did you verify your code works?

• Built packages/opencode successfully (bun run build)
• Ran core test suite: 1058/1060 pass (2 pre-existing failures unrelated)
• No TypeScript errors in modified files
• Changes are Windows-only (process.platform === "win32" guard)

Checklist

• I have tested my changes locally
• I have included no unrelated changes

Issue for this PR

Fixes#30374

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found:

• PR fix(session): normalize Windows directory paths in session list #30367 - fix(session): normalize Windows directory paths in session list
  • fix(session): normalize Windows directory paths in session list #30367
  • This PR appears to address the same issue: normalizing Windows directory paths for session list queries. It likely handles the path separator mismatch problem between POSIX format storage and backslash query parameters on Windows.

Related PR:

• PR fix: Windows session path, shell env, error message, and autocomplete #31946 - fix: Windows session path, shell env, error message, and autocomplete
  • fix: Windows session path, shell env, error message, and autocomplete #31946
  • Addresses related Windows path handling issues in session context.

Check PR #30367 in detail—it may already solve this problem or provide relevant context for the current fix.

[github-actions]

Thanks for updating your PR! It now meets our contributing guidelines. 👍

[VoidPurifier]

Correction: the actual root cause is different

The dbDir() normalization in this PR is a minor safety net but does not fix the reported issue. The real root cause was found by inspecting the production DB on a real Windows installation.

What the DB revealed

All 1052 sessions (from first use on May 24 to present) have:

Column	Value
directory	"C:/"
project_id	"global"
path	"" (empty)

No session has ever been stored with a real workspace directory.

Why this happens

Storage side — ProjectV2.resolve() at packages/core/src/project.ts:111-112:

constrepo=yield*git.repo.discover(input)if(!repo)return{id: ID.global,directory: AbsolutePath.make(path.parse(input).root),vcs: undefined}

When no git repo is found (user works outside a git repo, or discovery fails), it returns the drive root (C:/) as the project directory. Sessions are then created via InstanceStore.boot which resolves the project context, and ctx.directory ends up as C:/. All sessions inherit this.

Query side — V2Session.list() at packages/core/src/session.ts:276:

if("directory"ininput)conditions.push(eq(SessionTable.directory,dbDir(input.directory)))

The web app's loadRootSessionsWithFallback always passes the real working directory in the query. The DB has "C:/", the query looks for "C:/Users/<user>/..." → zero matches.

Why the backslash fix is insufficient

Drizzle's directoryColumn.toDriver() already normalizes \ → / on both INSERT and WHERE. The dbDir() wrapper is redundant. The actual mismatch isn't \ vs / — it's "C:/" (stored) vs "C:/Users/..." (queried). This is a directory value mismatch, not a format mismatch.

Suggested proper fix

Option A — Change ProjectV2.resolve() to keep the original input directory when no git repo is found:

if(!repo)return{id: ID.global,directory: input,vcs: undefined}

Sessions would then store the user's real working directory. toDriver() handles the normalisation to POSIX format on INSERT.

Option B — Skip directory filter for global-project sessions in V2Session.list():

if("directory"ininput&&input.directory!=="C:/"){conditions.push(eq(SessionTable.directory,dbDir(input.directory)))}

Or better, check against the project ID when available.

This PR's status

The dbDir() changes are a harmless safety net but do not resolve #30374. The session-list-empty-on-restart bug will persist until the directory value mismatch above is addressed. I'll submit a follow-up with the correct fix once I can test it.

[Hona]

Thanks for the effort here, but closing this as the change is a no-op.

Path separator handling was fixed in #29666 (shipped in v1.16.0) at the database boundary: SessionTable.directory is a Drizzle custom column type (packages/core/src/database/path.ts) whose toDriver normalizes \ -> / on win32 for both writes and values bound in eq()/inArray(). So dbDir() re-normalizes a parameter that the column codec normalizes anyway — zero behavior change on every platform.

This is covered by an existing test: packages/core/test/database-migration.test.ts ("maps native Windows paths through database columns") queries eq(SessionTable.directory, "C:\\Repo\\...") against forward-slash storage and passes on Windows today.

Your follow-up comment reaches the same conclusion, so no disagreement there. The directory = "C:/" rows in your database are a separate value mismatch (not a separator issue) — the drive-root fallback in ProjectV2.resolve only feeds ProjectTable.worktree, never SessionTable.directory, in current code, so those rows likely predate v1.16.0 or came from a server process started at the drive root. If you can reproduce sessions being stored with a wrong directory value on >= v1.16.0, please open a targeted issue with the repro rather than a separator patch.