Skip to content

fix(core): stop after declined permissions - #35356

Merged
rekram1-node merged 1 commit into
devfrom
permission-outcomes
Jul 4, 2026
Merged

fix(core): stop after declined permissions#35356
rekram1-node merged 1 commit into
devfrom
permission-outcomes

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • rename V2 permission DeniedError/RejectedError to BlockedError/DeclinedError
  • keep policy blocks and corrections model-facing while stopping the active runner when a user declines approval
  • add permission and runner regressions for blocked, declined, and corrected outcomes

Source: https://discord.com/channels/1391832426048651334/1523051301674549390

Tests

  • bun test test/session-runner.test.ts test/permission.test.ts test/tool-question.test.ts test/tool-write.test.ts test/tool-todowrite.test.ts test/tool-bash.test.ts test/tool-edit.test.ts test/tool-skill.test.ts test/tool-read.test.ts test/tool-apply-patch.test.ts
  • GOMAXPROCS=4 bun typecheck

@rekram1-node
rekram1-node marked this pull request as ready for review July 4, 2026 20:07
@rekram1-node
rekram1-node merged commit 709af58 into devJul 4, 2026
10 checks passed
@rekram1-node
rekram1-node deleted the permission-outcomes branch July 4, 2026 21:17
Wiktor102 pushed a commit to Wiktor102/opencode that referenced this pull request Jul 5, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
drewr pushed a commit to drewr/opencode that referenced this pull request Jul 7, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
shaheislam pushed a commit to shaheislam/opencode-vim that referenced this pull request Jul 7, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 20, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
3kaiu pushed a commit to 3kaiu/opencode-x that referenced this pull request Jul 31, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
banlanzs pushed a commit to banlanzs/opencode that referenced this pull request Aug 6, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
charlesverge pushed a commit to charlesverge/opencode that referenced this pull request Aug 11, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rekram1-node