Uh oh!
There was an error while loading. Please reload this page.
fix(app): optimize large review panes - #35375
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the performance and scalability of the v2 review pane by normalizing review file-tree data, applying bounded TanStack virtualization to the review sidebar + filtered file list, and reducing expensive UI observation work during tab switching. It also adds automated Playwright performance benchmarks to validate behavior from small reviews up through extreme 10k-file scenarios.
Changes:
- Replace the recursive review file tree with a normalized, flattened model and TanStack virtualization for both the tree and filtered-results list.
- Adjust review pane mounting/tab-panel behavior to avoid expensive tab-content observation, plus prewarm the diff worker pool.
- Add/extend unit + Playwright regression tests and introduce a production scaling benchmark spec for large review panes.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/session-ui/src/v2/components/session-review-v2.tsx | Prewarms Pierre diff worker pool when review mounts. |
| packages/session-ui/src/v2/components/session-review-file-preview-v2.tsx | Adds heuristic to disable diff virtualization for smaller diffs. |
| packages/session-ui/src/v2/components/session-review-file-preview-v2-virtualize.ts | Introduces shouldVirtualizeReviewDiff threshold logic. |
| packages/session-ui/src/v2/components/session-review-file-preview-v2-virtualize.test.ts | Unit tests for the virtualization threshold helper. |
| packages/app/src/pages/session/v2/session-file-list-v2.tsx | Virtualizes filtered review results list with focus retention + scroll-to-highlight. |
| packages/app/src/pages/session/v2/review-panel-v2.tsx | Uses virtualized file list while searching; updates FileTreeV2 usage. |
| packages/app/src/pages/session/v2/review-diff-kinds.ts | Centralizes path normalization via normalizeFileTreeV2Path. |
| packages/app/src/pages/session/v2/review-diff-kinds.test.ts | Adds test coverage for file/directory path normalization. |
| packages/app/src/pages/session/session-side-panel.tsx | Reworks review tabpanel mounting/ARIA to avoid costly observation; adds focusability hook. |
| packages/app/src/pages/session.tsx | Wires reviewHasFocusableContent into SessionSidePanel. |
| packages/app/src/components/file-tree-v2.tsx | Replaces recursive tree rendering with normalized model + TanStack virtualization. |
| packages/app/src/components/file-tree-v2-model.ts | Adds normalized tree model builder + flattening for virtualization. |
| packages/app/src/components/file-tree-v2-model.test.ts | Unit tests for sorting, collapsing, normalization, and deep paths. |
| packages/app/e2e/regression/review-tab-switch.spec.ts | Extends regression to assert tab/tabpanel ARIA wiring. |
| packages/app/e2e/performance/timeline/review-pane-scaling-benchmark.spec.ts | Adds scaling benchmark coverage (1 → 10,000 files; capped/uncapped payloads). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
21
| import FileTree from "@/components/file-tree" | ||
| import { SessionContextUsage } from "@/components/session-context-usage" | ||
| const reviewTabID = "session-side-panel-review-tab" | ||
| const reviewTabPanelID = "session-side-panel-review-tabpanel" | ||
| import { SessionContextTab, SortableTab, FileVisual } from "@/components/session" | ||
| import { useCommand } from "@/context/command" |
| export function flattenFileTreeV2(model: FileTreeV2Model, expanded: (path: string) => boolean) { | ||
| const rows: FileTreeV2Row[] = [] | ||
| const stack = (model.children.get("") ?? []).toReversed().map((node) => ({ node, level: 0 })) |
Comment on lines
+132
to
155
| const model = createMemo(() => buildFileTreeV2Model(props.allowed ?? [])) | ||
| const rows = createMemo(() => flattenFileTreeV2(model(), (path) => file.tree.state(path)?.expanded ?? true)) | ||
| const [root, setRoot] = createSignal<HTMLDivElement>() | ||
| const [focused, setFocused] = createSignal<string>() | ||
| const virtualizer = createVirtualizer<HTMLDivElement, HTMLDivElement>({ | ||
| get count() { | ||
| return rows().length | ||
| }, | ||
| getScrollElement: () => root()?.closest<HTMLDivElement>(".scroll-view__viewport") ?? null, | ||
| estimateSize: () => 28, | ||
| gap: 2, | ||
| overscan: 10, | ||
| get getItemKey() { | ||
| const current = rows() | ||
| return (index: number) => current[index]?.node.path ?? index | ||
| }, | ||
| rangeExtractor: (range) => { | ||
| const indexes = defaultRangeExtractor(range) | ||
| const path = focused() | ||
| const index = path ? rows().findIndex((row) => row.node.path === path) : -1 | ||
| if (index < 0 || indexes.includes(index)) return indexes | ||
| return [...indexes, index].sort((a, b) => a - b) | ||
| }, | ||
| }) |
Comment on lines
+166
to
+170
| const rowByKey = createMemo(() => new Map(rows().map((row) => [row.node.path, row] as const))) | ||
| const virtualItemByKey = createMemo( | ||
| () => new Map(virtualizer.getVirtualItems().map((item) => [item.key, item] as const)), | ||
| ) | ||
| const nodes = createMemo(() => visibleNodesForPath(props.path, file.tree.children, filter())) | ||
| const virtualRowKeys = createMemo(() => virtualizer.getVirtualItems().map((item) => item.key)) |
Comment on lines
+64
to
+68
| rangeExtractor: (range) => { | ||
| const indexes = defaultRangeExtractor(range) | ||
| const path = focused() | ||
| const index = path ? props.files.indexOf(path) : -1 | ||
| if (index < 0 || indexes.includes(index)) return indexes |
Comment on lines
+81
to
+84
| const virtualItemByKey = createMemo( | ||
| () => new Map(virtualizer.getVirtualItems().map((item) => [item.key, item] as const)), | ||
| ) | ||
| const virtualRowKeys = createMemo(() => virtualizer.getVirtualItems().map((item) => item.key)) |
Uh oh!
There was an error while loading. Please reload this page.
drewr pushed a commit
to drewr/opencode
that referenced
this pull request
Jul 7, 2026
shaheislam pushed a commit
to shaheislam/opencode-vim
that referenced
this pull request
Jul 7, 2026
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 9, 2026
anduimagui pushed a commit
to anduimagui/opencode
that referenced
this pull request
Jul 9, 2026
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 11, 2026
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 20, 2026
3kaiu pushed a commit
to 3kaiu/opencode-x
that referenced
this pull request
Jul 31, 2026
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
banlanzs pushed a commit
to banlanzs/opencode
that referenced
this pull request
Aug 6, 2026
charlesverge pushed a commit
to charlesverge/opencode
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Scaling graph
The legend is rendered in the chart title. Values are stable render time in milliseconds; file counts progress logarithmically.
The VCS-capped result uses REVIEW_PANE_PATCH_BYTE_LIMIT=10000000 to mirror the server aggregate patch cap. Broad filtering across 10,000 results stabilizes in about 50-100 ms.
Test plan