Uh oh!
There was an error while loading. Please reload this page.
fix(opencode): stop silent session title generation failures - #35440
fix(opencode): stop silent session title generation failures#354401837620622 wants to merge 1 commit into
Conversation
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The following comment was made by an LLM, it may be inaccurate: Based on my search results, I found several related PRs that address session title generation: Potentially Related PRs
These are related to session title generation and the underlying infrastructure (model resolution, configuration), but none appear to be direct duplicates addressing the same silent error failure issue that PR #35440 targets. |
7140b3f to
a65c89dCompare9230382 to
ace8cffCompareThanks for updating your PR! It now meets our contributing guidelines. 👍 |
1837620622
commented
Jul 5, 2026
@maintainers This PR addresses the root cause of the intermittent auto-naming failure reported in #13710. Summary of the approach: The three bugs form a chain — any of them alone would cause silent failure. The fix addresses all three at their source:
The retry path was added as a safety net: if the first attempt produces no title (regardless of the reason), wait 10 seconds for more conversation context, verify the title is still the default, and try again with the full history. This is more robust than patching individual error causes because it handles:
|
adbebc5 to
9976269Compare1837620622
commented
Jul 11, 2026
Ready for reviewThis is a minimal, confirmed fix for intermittent silent auto-title failures (#13710). Why this is safe to merge
AskCould a maintainer review/merge when convenient? Happy to iterate on any nits. |
ensureTitle failed silently when model resolution or the title LLM stream errored, leaving sessions on "New session - …". Confirmed causes (anomalyco#13710): 1. getModel Fail killed the forked fiber 2. Effect.orDie turned stream errors into unlogged defects 3. Effect.ignore at the call site swallowed remaining failures Minimal fix only (no retry policy change): - Model resolution via Effect.option + warning log - Stream Effect.orDie → Effect.catchAll (log + empty text) - Call site Effect.ignore → Effect.catchCause (skip interrupt-only) - Keep small:true for smallOptions / no variant leakage Fixesanomalyco#13710
ba48956 to
8c16c4bCompare1837620622
commented
Jul 11, 2026
Review-ready (optimized)Slimmed to a minimal, mergeable fix for #13710:
~30 lines, single file, all checks green. Thanks for review. |
1837620622
commented
Jul 11, 2026
Friendly ping for review when you have a moment 🙏 Minimal fix for intermittent silent auto-title failures (#13710):
~30 lines, checks green, ready to merge. Happy to address any nits quickly. |
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes#13710
Type of change
What does this PR do?
Session auto-naming (
ensureTitle) can fail silently, leaving sessions asNew session - <timestamp>.Confirmed root causes on
dev:getModelFail → fiber diesEffect.option+ warning logEffect.orDie→ unlogged defectEffect.catchAll→ log + empty textEffect.ignoreswallows everythingEffect.catchCauselogs (skips interrupt-only)small: truesmallOptions, avoids #20269 / #20323)Out of scope: multi-provider fallback, smallOptions gaps, speculative multi-second retry loops.
How did you verify your code works?
ensureTitlefailure chainAuthor
35034498+1837620622@users.noreply.github.com(GitHub-verified)Checklist