Uh oh!
There was an error while loading. Please reload this page.
fix(cli): answer subagent permission asks in headless run (#35073) - #35823
Closed
IsaVonxz-type wants to merge 7 commits into
Closed
fix(cli): answer subagent permission asks in headless run (#35073)#35823IsaVonxz-type wants to merge 7 commits into
IsaVonxz-type wants to merge 7 commits into
Conversation
Sync/background subagents run in their own child session with no human attached. The headless `opencode run` responder only replied to asks whose sessionID matched the top-level session, so a subagent that hit a tool with permission set to "ask" hung forever waiting for a reply that never came. Recognize asks from any descendant session by walking the parentID chain (new isSessionInTree helper) and answer them with the same policy as the top-level session: reply "once" under --auto, otherwise reject so the subagent fails closed instead of hanging. Scoped to the headless responder; the TUI/desktop already surface subagent asks via lineage. Closesanomalyco#35073
6 tasks
Contributor
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#35073
Type of change
What does this PR do?
Sync subagents (spawned by the
tasktool withoutbackground) run in their own child session with no human attached. In headlessopencode run, the event responder only replied to permission asks whosesessionIDmatched the top-level session (if (permission.sessionID !== sessionID) continue). When a subagent hit a tool with permission set toask, its ask was dropped and the Deferred in the permission service was never resolved, so the subagent hung forever.This walks the
parentIDchain of the asking session (newisSessionInTreehelper, the same lineage approach the app'spermission-auto-respondalready uses) and answers asks from any descendant session with the same policy as the top-level one: replyonceunder--auto, otherwiserejectso the subagent fails closed instead of hanging. Only the headless responder changes — the TUI/desktop already surface subagent asks to the user, so no server-side behavior is touched.How did you verify your code works?
test/cli/run/session-tree.test.tscovering the lineage check: self, direct child, nested descendant, unrelated tree, ancestor, and a cyclic parent chain.bun test test/cli/run/— 199 pass, 0 fail.bun run typecheck(packages/opencode) — clean.prettier --checkandoxlinton the changed files — clean.Screenshots / recordings
N/A — no UI change.
Checklist