Skip to content

feat(tui): preserve selected thinking effort per agent per model for primary agents - #36708

Closed
IdrisGit wants to merge 1 commit into
anomalyco:devfrom
IdrisGit:feat-preserve-thinking-effort-when-changing-agent
Closed

feat(tui): preserve selected thinking effort per agent per model for primary agents#36708
IdrisGit wants to merge 1 commit into
anomalyco:devfrom
IdrisGit:feat-preserve-thinking-effort-when-changing-agent

Conversation

@IdrisGit

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes#36703

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Variant (thinking effort) selection was stored keyed only by providerID/modelID, so Primary Agents sharing the same model would overwrite each other's setting. Now the key includes the agent name so each primary agent holds its own thinking effort independently. i.e name/providerID/modelID

How did you verify your code works?

  1. Ran TUI locally using bun dev
  2. Tested with same model on different agents with different thinking effort
  3. On each cycle the thinking effort is preserved per agent per model

Screenshots / recordings

oc_preserve_thinking_effort.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

Related PR:

The search also returned a couple of other thinking/preservation-related PRs (#12567, #32604) but they're less directly related (subagent inheritance and session-level reasoning preservation).

Note: PR #36708 (your current PR) appears in all results, which is expected.

@soltrac

Copy link
Copy Markdown

this is very interesting to have

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: preserve model thinking effort setting when switching between primary agents with same model selected.

2 participants

@IdrisGit@soltrac