Uh oh!
There was an error while loading. Please reload this page.
fix: custom tools with args tolerate undefined input (#30219, #20019) - #36760
Closed
pacificera wants to merge 1 commit into
Closed
fix: custom tools with args tolerate undefined input (#30219, #20019)#36760pacificera wants to merge 1 commit into
pacificera wants to merge 1 commit into
Conversation
…anomalyco#20019) Prevent crash when AI SDK passes undefined args to custom plugin tools. Mirrors the MCP tools fix from anomalyco#11203 that was never applied to the custom-tool code path. Two changes in fromPlugin's execute wrapper: 1. Coerce undefined args to {} — prevents downstream crashes 2. Validate through Zod schema — gives the LLM structured errors via InvalidArgumentsError so it can retry with valid input Regression tests: - Optional Zod args: undefined input returns {} instead of crashing - Required Zod args: undefined input fails with validation error
Contributor
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent
p.splitcrash when AI SDK passes undefined args to custom plugin tools. Mirrors the MCP tools fix from #11203 that was never applied to the custom-tool code path.Changes
Two changes in
fromPlugin's execute wrapper (src/tool/registry.ts):{}— prevents downstreamp.splitcrash when the AI SDK omits optional argsInvalidArgumentsErrorso it can retry with valid input, matching the validation behavior built-in tools get throughwrap()Tests
{}instead of crashingInvalidArgumentsErrorCloses#30219, closes#20019