Uh oh!
There was an error while loading. Please reload this page.
fix(app): enable remote session auto-accept - #36777
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes remote-session “auto-accept permissions” configuration by ensuring the Settings command (and resulting dialog) is registered within the active server/session route context, so the dialog inherits the correct server-scoped providers (notably ServerSync/Permission).
Changes:
- Move Settings command registration out of the global new-layout shell and into the active routes (home, new-session, target session) so dialogs inherit correct server context.
- Keep remote session settings under the session-scoped
PermissionProvider(including when the session route is rendering error fallbacks). - Add an E2E regression test verifying auto-accept can be toggled for a session on a remote server.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/app/src/pages/session.tsx | Wrap target session route in PermissionProvider and register settings command within that provider scope for correct server/session context. |
| packages/app/src/pages/new-session.tsx | Register the Settings command on the new-session route so the dialog is available with correct route context. |
| packages/app/src/pages/layout-new.tsx | Remove global Settings command registration from the new-layout shell. |
| packages/app/src/pages/home.tsx | Switch to useSettingsCommand() so the Settings command is registered (and an open callback is available) in the home route context. |
| packages/app/e2e/regression/remote-tab-busy.spec.ts | Add a regression test ensuring remote-session auto-accept can be enabled via the Settings dialog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch Please resolve this issue to include this PR in the next beta release. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Testing