Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): validate openExternal URLs by protocol - #36862
Closed
ulises-jeremias wants to merge 1 commit into
Closed
fix(desktop): validate openExternal URLs by protocol#36862ulises-jeremias wants to merge 1 commit into
ulises-jeremias wants to merge 1 commit into
Conversation
shell.openExternal accepts any URL without validation, allowing potentially dangerous protocols like file://, javascript:, and smb:. This adds an isSafeExternalLink() guard that restricts open-link IPC calls to http: and https: URLs only. Closesanomalyco#30613
6 tasks
Contributor
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#30613
Type of change
What does this PR do?
shell.openExternalaccepts any URL without validation, allowing potentially dangerous protocols likefile://,javascript:, andsmb:. This adds anisSafeExternalLink()guard that restrictsopen-linkIPC calls tohttp:andhttps:URLs only, with dedicated helper module for testability.How did you verify your code works?
bun test src/main/external-link.test.ts— 3 tests pass covering allowed protocols, blocked protocols, and malformed URLsbun typecheck(desktop package) — cleanScreenshots / recordings
N/A (no UI changes)
Checklist