Skip to content

fix(app): preserve themed diff backgrounds - #36931

Merged
Hona merged 2 commits into
anomalyco:devfrom
Hona:diff-background-fix
Jul 14, 2026
Merged

fix(app): preserve themed diff backgrounds#36931
Hona merged 2 commits into
anomalyco:devfrom
Hona:diff-background-fix

Conversation

@Hona

@HonaHona commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve the V2 file-view background override
  • fall back to OpenCode's themed background for timeline, review, and legacy diff views
  • add a regression test for the default diff background

Tests

  • bun run test (packages/session-ui)
  • bun typecheck (packages/session-ui)
  • bun turbo typecheck (pre-push hook)

CopilotAI review requested due to automatic review settings July 14, 2026 20:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Session UI diff styling so Pierre-based diffs preserve OpenCode’s themed background behavior: honoring the --opencode-diffs-bg override when present (V2 file view) and otherwise falling back to OpenCode’s standard themed background token.

Changes:

  • Simplified --diffs-bg to prefer --opencode-diffs-bg and fall back to --color-background-stronger.
  • Added a regression test to ensure the default diff background CSS stays consistent.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

FileDescription
packages/session-ui/src/pierre/index.tsUpdates the Pierre unsafeCSS background variable fallback chain to use OpenCode theme tokens.
packages/session-ui/src/pierre/index.test.tsAdds a regression test asserting the expected --diffs-bg CSS declaration is present.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Hona
Hona merged commit 3615793 into anomalyco:devJul 14, 2026
9 checks passed
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 17, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 20, 2026
3kaiu pushed a commit to 3kaiu/opencode-x that referenced this pull request Jul 31, 2026
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
banlanzs pushed a commit to banlanzs/opencode that referenced this pull request Aug 6, 2026
charlesverge pushed a commit to charlesverge/opencode that referenced this pull request Aug 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hona