Skip to content

fix(app): hide drawer close button on Windows - #36952

Merged
Hona merged 2 commits into
anomalyco:devfrom
Hona:windows-drawer-close
Jul 14, 2026
Merged

fix(app): hide drawer close button on Windows#36952
Hona merged 2 commits into
anomalyco:devfrom
Hona:windows-drawer-close

Conversation

@Hona

@HonaHona commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

  • hide the tabs info drawer close button on Windows desktop
  • retain the close button on macOS, Linux, and web

Testing

  • bun typecheck

@Hona
Hona requested a review from Brendonovich as a code ownerJuly 14, 2026 22:21
CopilotAI review requested due to automatic review settings July 14, 2026 22:21
@Hona
Hona merged commit 571e7b8 into anomalyco:devJul 14, 2026
6 checks passed

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Tabs info drawer UI so the drawer close button is hidden on Windows desktop while remaining visible on macOS, Linux, and web, and adds a small unit test to lock in the platform/OS visibility behavior.

Changes:

  • Wrap the drawer close button in a platform/OS gate so it does not render on Windows desktop.
  • Introduce a small visibility helper (tabsDrawerHasCloseButton) to centralize the condition.
  • Add a unit test covering the expected visibility matrix across desktop OSes and web.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

FileDescription
packages/app/src/components/help-button.tsxConditionally renders the drawer close button based on platform + OS.
packages/app/src/components/help-button-visibility.tsAdds a helper function encapsulating the close-button visibility rule.
packages/app/src/components/help-button.test.tsAdds a unit test validating visibility behavior for Windows desktop vs other platforms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

molicherry added a commit to molicherry/opencode that referenced this pull request Jul 15, 2026
- fix(app): hide drawer close button on Windows (anomalyco#36952)
- fix(opencode): default Meta reasoning to xhigh (anomalyco#36976)
- fix(app): tolerate null session archive times (anomalyco#36999)
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 17, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 20, 2026
3kaiu pushed a commit to 3kaiu/opencode-x that referenced this pull request Jul 31, 2026
banlanzs pushed a commit to banlanzs/opencode that referenced this pull request Aug 6, 2026
charlesverge pushed a commit to charlesverge/opencode that referenced this pull request Aug 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hona