Uh oh!
There was an error while loading. Please reload this page.
fix(app): show shell output while a command runs - #37097
Closed
HopelessLoop wants to merge 9 commits into
Closed
Conversation
The web UI collapsed bash tool output by default, so while a shell command executed the user only saw the "Shell" header with a spinner and could not expand it. Expand the tool while its status is running or pending so the command and live output are visible, matching the TUI. After completion it falls back to the shellToolPartsExpanded setting.
6 tasks
6 tasks
Contributor
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web UI collapsed bash tool output by default, so while a shell command executed the user only saw the "Shell" header with a spinner and could not expand it. Expand the tool while its status is running or pending so the command and live output are visible, matching the TUI. After completion it falls back to the shellToolPartsExpanded setting.
Issue for this PR
Closes#22116#37094
Type of change
What does this PR do?
In the web UI a shell command (shell mode or
/shell) only showed the "Shell" header with a spinner while it ran. The command and its live output were hidden, and the tool could not be expanded. The TUI renders the samebashtool part inline with the command and streaming output.This makes the web match the TUI:
partDefaultOpennow returnstruefor abashtool whose status isrunningorpending, so the tool auto-expands during execution.pending(previously only when not running and not open).After completion the tool falls back to the
shellToolPartsExpandedsetting, so the existing collapsed-by-default behavior for finished commands is unchanged.How did you verify your code works?
tsgo --noEmitpasses for packages/session-ui.bashtool part and streams output intostate.metadata.output, finalizingstate.output(packages/opencode/src/session/prompt.ts). Both UIs render it through the sharedbashregistry in session-ui, so expanding the part duringrunning/pendingsurfaces the same command and output the TUI already shows.shellToolPartsExpandedsetting.Screenshots / recordings
Checklist