Skip to content

fix(desktop): restrict external links - #38914

Closed
opencode-agent[bot] wants to merge 1 commit into
v2from
desktop-safe-links
Closed

fix(desktop): restrict external links#38914
opencode-agent[bot] wants to merge 1 commit into
v2from
desktop-safe-links

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • validate renderer-provided external URLs in the main process
  • allow only HTTP and HTTPS links before calling shell.openExternal
  • reject file, executable/custom-protocol, and malformed URLs

Checks

  • bun test src/main/external-link.test.ts
  • bun typecheck

Requested by: @Brendonovich (Brendan Allan via Slack)

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Brendonovich