Uh oh!
There was an error while loading. Please reload this page.
feat(desktop): add Electron browser adapter - #39273
Closed
Hona wants to merge 1 commit into
Closed
Conversation
Honaforce-pushed
the
desktop-browser
branch
2 times, most recently
from
July 28, 2026 09:03
dfae385 to
3796a8cCompareHonaforce-pushed
the
browser-chromium-driver
branch
from
July 28, 2026 11:34
5a236ed to
e8c3987CompareHonaforce-pushed
the
browser-chromium-driver
branch
from
July 29, 2026 06:05
057d028 to
4205af5CompareHona
commented
Jul 29, 2026
MemberAuthor
Superseded by the simplified Desktop/App PR #39278. The reduced Electron adapter and on-demand App surface are now reviewed together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the thin Electron adapter. Desktop registers the active Session without creating Chromium, reveals the pane on the client open event, and attaches Chromium only while visible. It owns the isolated WebContentsView, plain authenticated proxy setup, typed IPC, bounds, origin policy, and cleanup.
No cross-window ownership transfer, endpoint revisions, retained contexts, crash reattachment, or decorative masks.
Verification
Desktop and App typechecks pass. All 69 Desktop tests pass, including the observed destroyed-window cleanup regression. Production Desktop build succeeds.
Checklist