Uh oh!
There was an error while loading. Please reload this page.
fix(opencode): guard shell permission parse failures - #39938
Open
nikitakot wants to merge 1 commit into
Open
Conversation
Contributor
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
nikitakot
commented
Aug 18, 2026
Author
@Hona@rekram1-node hey folks can someone have a look at it? the issue is also present in V2 tldr.: permissions should not be escaped completely when shell command parsing fails, this PR tries to fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#39931
Type of change
What does this PR do?
PowerShell parsing can return an error tree with no command patterns, causing the shell permission check to be skipped. When the syntax tree contains errors, this change checks the raw command instead and avoids deriving a reusable approval pattern from the invalid tree.
How did you verify your code works?
bun test test/tool/shell.test.ts --timeout 30000 -t "falls back to the raw command"bun typecheckbunx prettier --check src/tool/shell.ts test/tool/shell.test.tsScreenshots / recordings
Not applicable.
Checklist