Skip to content

fix(github): support immutable OIDC subjects - #40365

Closed
opencode-agent[bot] wants to merge 1 commit into
devfrom
github-oidc-claims
Closed

fix(github): support immutable OIDC subjects#40365
opencode-agent[bot] wants to merge 1 commit into
devfrom
github-oidc-claims

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • derive the repository identity from GitHub’s signed repository OIDC claim instead of parsing the mutable shape of sub
  • cover both legacy and immutable subject formats with focused claim-parsing tests
  • preserve the original exchange failure when the API returns non-JSON and avoid attempting to comment before GitHub clients are initialized

Checks

  • bun test in packages/function (4 passing)
  • bun test test/cli/github-action.test.ts in packages/opencode (17 passing)
  • Prettier checks for all changed files
  • Oxlint (0 errors)

Fixes#37823

Requested by: @rekram1-node (Aiden Cline via Slack)

@chAwater

Copy link
Copy Markdown

Hi, @rekram1-node

@0xjei

Copy link
Copy Markdown

bump

@neriousy

Copy link
Copy Markdown
Contributor

Thanks @rekram1-node for the repository-claim implementation and focused tests. This is superseded by #44776 on dev and #44778 on v2, which carry the same approach with the final broker and action error handling. Closing to consolidate the work.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub action fails on repos created after 2026-07-15 (new OIDC sub format)

4 participants

@chAwater@0xjei@neriousy@rekram1-node