Uh oh!
There was an error while loading. Please reload this page.
test(app): harden flaky e2e synchronization - #40556
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
waitForConnection should dispose the Playwright JSHandle via try/finally to avoid leaking handles when jsonValue() throws.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR strengthens app E2E regression coverage by replacing timing-sensitive interactions with more deterministic Playwright assertions around SSE transport readiness, timeline stability, and review comment UI state.
Changes:
- Update SSE transport
waitForConnectionto return the active connection record viapage.waitForFunction(filtering out ended connections). - Harden session timeline transport regression tests with stable timeline-row snapshots, explicit heartbeat consumption checks, and polling-based connection assertions.
- Reduce flakiness in review line-comment regression tests by asserting accessible/observable UI readiness (labels, hover state) and using
dragToinstead of manual mouse coordinates.
File summaries
| File | Description |
|---|---|
| packages/app/e2e/utils/sse-transport.ts | Makes connection waiting return the active connection record from the page-side transport state. |
| packages/app/e2e/regression/session-timeline-transport.spec.ts | Reworks assertions to be state-based (polling + stable row snapshots), improving determinism across reconnect/heartbeat cases. |
| packages/app/e2e/regression/review-line-comment.spec.ts | Replaces timing-sensitive hover/click flows with explicit UI readiness assertions and more robust interactions. |
| packages/app/e2e/performance/timeline-stability/fixture.ts | Tightens waitForPart to require a single visible match, catching duplicate/stale timeline parts. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Testing