Uh oh!
There was an error while loading. Please reload this page.
refactor(server): resume suspended sessions unconditionally in the fetch entry - #41938
Merged
Conversation
…tch entry The Node server process has resumed unconditionally since the mechanism existed; the sweep filters live claims and is a no-op when nothing is suspended, so an opt-in flag whose only conceivable caller passes true was speculative API. ServerFetch.make now resumes exactly as ServerProcess.start does, and the empty BootOptions bag goes away.
kitlangton
enabled auto-merge (squash)
August 12, 2026 03:22
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
ServerFetch.BootOptions.resumeSuspendedSessions(added in #41896) and makes the web-standard fetch entry resume execution-claimed Sessions unconditionally after the layer builds, matchingServerProcess.start(which has resumed unconditionally since #36105).Why
The flag was speculative API: the resume sweep filters live claims and is a no-op when nothing is suspended, so there is no embedder that wants
false— a runtime with a fresh:memory:database has nothing to resume, and a runtime with durable storage wants orphaned turns replayed. The only caller that would ever exist passestrue(the workerd profile in #41918, which simplifies further on top of this).Testing
packages/serversuite green (32 tests) including theServerFetchhandler tests.