Allow line numbers and ranges in autocomplete

[ewired]

No description provided.

[rekram1-node]

For line ranges they should be the same format as we have for other things:

@file#11-23

I think that's what vscode extension does correct?

[ewired]

@rekram1-node Sounds good to me, I changed it over

[rekram1-node]

/review

[github-actions]

Style suggestion: The let statements for url and filename could be avoided using an IIFE pattern (see packages/opencode/src/util.iife.ts for reference). However, this is minor and the current implementation is still readable - feel free to keep as-is if you prefer the simplicity.

[rekram1-node]

when I get a chance ill pull it down and try it I think this will be a good addition if its done well

[rekram1-node]

How do I get it to trigger?

[ewired]

It must be triggered by typing # at any point while the autocomplete is open and showing some files. When you have a valid line range or line number, all the files in the autocomplete selection will have it, and when you accept one it will be included. Given the way mentions work, you couldn't type in line numbers after you inserted the filename mention without numbers. This is consistent with being unable to change the filename, for example, selecting Makefile and then typing .xyz would still mention Makefile and not Makefile.xyz. Maybe this is confusing for people used to the vscode extension and could be fixed, but it would need a lot of extra behavior changes to consistently allow editing mentions after they're selected.

[rekram1-node]

Hm seems to work intermittently but not reliably

Also it feels kinda weird that I can't autocomplete the file at all and then add line numbers to it in any way

[ewired]

The intermittent display here is because it only respects valid line ranges where the end is greater than the start. As soon as you type one more digit in the number after the dash there, it will be greater than 11 and show the range on all the files. This could have definitely been better, now it uses only the start value while you're still typing an invalid range. It will reject any non-numeric input besides a trailing dash in any part of the range. This prevents it from being so jumpy while typing now.