You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AI code review — automated review for reference; please use your judgment.
packages/opencode/src/lsp/language.ts — unlike the sibling Taplo change (feat(lsp): add Taplo language server for TOML #42937), this PR adds the server but does not register .md/.markdown in LANGUAGE_EXTENSIONS; if that map participates in deciding which built-in server attaches to a file (as .toml": "toml" just did), Marksman may never be selected despite being registered — please either add the two mappings for consistency or explain why Markdown is exempt.
packages/opencode/src/lsp/server.ts:1988 — spawn(bin, ["server"]) relies on stdio being Marksman's default transport (it is today); passing --stdio explicitly would pin the contract against a future CLI default change — cheap insurance for a long-lived builtin entry.
Nit — packages/web/src/content/docs/lsp.mdx:33 — same follow-up as other manual servers: Marksman ships single static binaries on GitHub releases, so an auto-install path would spare most users the manual step; fine to defer.
Overall: clean addition following the established builtin-server pattern (registration, graceful missing-binary no-op, root markers, alphabetized docs). Item 1 is the one thing to verify before merge. Thanks!
Point 1 isn't relevant - Markdown is already in LANGUAGE_EXTENSIONS.
As a Nix user, 3 and the concept of auto-installing things from the internet gets a "no" from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
None.
Type of change
What does this PR do?
Adds support for using https://github.com/artempyanykh/marksman as an LSP for Markdown.
How did you verify your code works?
Deployed the Nix flake for this branch and verified by having an LLM create and navigate a fake notes collection.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.