Uh oh!
There was an error while loading. Please reload this page.
fix(app): drop archived sessions from home list right away - #44905
Merged
Conversation
Contributor
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Brendonovich
enabled auto-merge (squash)
August 25, 2026 07:22
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#44619
Type of change
What does this PR do?
When a session is archived, it stayed visible in the Home list until a full refresh because the in-memory Home index cache was never updated.
This bug already existed before PR #41741 (register archive session command in both layouts), which re-enabled archiving . It was just hidden while archiving was broken. Restoring it brought the bug back.
This PR adds a
remove(sessionID)method to the Home index cache (home-session-index.ts), and call it right after archiving, both from Home (home-sessions-controller.tsx) and from the session route (session-archive.ts), so the archived session disappears from the Home list immediately.The remove call is a no-op when the Home index isn't mounted.
How did you verify your code works?
bun typecheck
Unit tests for home-session-index: removal of a session from the loaded index, and no-op when the index isn't mounted
Screenshots / recordings
Before
CleanShot.2026-08-25.at.08.48.18-converted.mp4
After
CleanShot.2026-08-25.at.08.52.15-converted.mp4
Checklist