Uh oh!
There was an error while loading. Please reload this page.
chore: bump embedded Bun to 1.4.0 - #44946
Open
AlexanderWillner wants to merge 3 commits into
Open
Conversation
When the chunk-timeout fires, the fetch-body reader is cancelled after the request signal is aborted. Under Bun 1.4 reader.cancel() then rejects, and the voided promise surfaces as an unhandled rejection that fails tests (and can crash strict runtimes). Handle the rejection explicitly.
The 5s deadline is load-sensitive: under a fully parallel test run the PTY exit event was observed too late and the test failed even though the behaviour under test is correct.
Runtime bump only. Depends on the SSE cancel-rejection and PTY poll deadline fixes on this branch so the suite stays green under 1.4. CI (.github/actions/setup-bun) reads packageManager, so release binaries embed Bun 1.4.0 automatically.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes#44945
Type of change
What does this PR do?
Bumps the pinned packageManager from bun@1.3.14 to bun@1.4.0. That field drives CI via .github/actions/setup-bun, and bun build --compile embeds the running runtime into release binaries — so this one line is the whole runtime upgrade.
The first two commits are the prerequisite fixes from #44944 (this branch builds on it); under Bun 1.4 the suite fails without them.
How did you verify your code works?
Built darwin-arm64 with Bun 1.4.0 (binary contains bun-v1.4.0, smoke test green) and ran the full packages/opencode suite: 3339 tests, 0 fail. Same suite green under 1.3.14 with these commits.
Checklist