Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): move platform creation before event listener - #8656
fix(desktop): move platform creation before event listener#8656jerome-benoit wants to merge 2 commits into
Conversation
Fixes typecheck error introduced in anomalyco#7360 where platform.openLink() was referenced before platform was defined. Move platform and serverPassword creation outside render() so they're available to the click event listener.
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript compilation error introduced in PR #7360 where platform.openLink() was referenced in an event listener before platform was defined. The solution moves the creation of platform and serverPassword signal outside the render() function to module scope.
Changes:
- Move
createSignalcall forserverPasswordfrom insiderender()to module scope - Move
createPlatform()call from insiderender()to module scope
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Eric-Guo
commented
Jan 15, 2026
LGTM! |
jerome-benoit
commented
Jan 15, 2026
fixed in dev |
What does this PR do?
Fixes typecheck error
TS2304: Cannot find name 'platform'introduced in #7360.Moves
platformandserverPasswordcreation outsiderender()so they're available to the click event listener that referencesplatform.openLink().Fixes#8657
How did you verify your code works?
bun run typecheck