Uh oh!
There was an error while loading. Please reload this page.
fix: Windows evaluating text on copy - #9293
Conversation
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found 3 potentially related PRs that deal with Windows/WSL clipboard functionality:
These PRs all touch the clipboard handling layer on Windows/WSL environments. You should verify if any address the same variable expansion issue or if they've already fixed this problem. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue on Windows where copying text containing PowerShell variables (like $env:FOO) would cause those variables to be evaluated/expanded due to PowerShell's string interpolation when passed as command-line arguments.
Changes:
- Modified Windows clipboard implementation to use stdin instead of command-line arguments
- Added explicit UTF-8 encoding configuration for PowerShell's input stream
- Aligned Windows implementation pattern with existing Linux clipboard implementations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
Fixes#8166
copying text like
on windows would expand these variables because it uses powershell
changes to use stdin - the same as linux clipboard
I found a duplicate PR - however mine stays consistent with linux
#8150
How did you verify your code works?
copying the same text on latest release and my branch on windows