Uh oh!
There was an error while loading. Please reload this page.
fix(core): plugins are always reinstalled - #9675
Merged
Merged
Conversation
…and Config to utilize it for dependency checks
…n checking in BunProc and Config modules
Contributor
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
The following comment was made by an LLM, it may be inaccurate: The search results show that PR #9675 (the current PR) appears in the results, but no other open or merged PRs with the exact same title exist. The other results are related to plugin management and fixes, but they appear to be distinct issues:
No duplicate PRs found |
Uh oh!
There was an error while loading. Please reload this page.
neriousy
marked this pull request as draft
January 20, 2026 20:27
neriousyforce-pushed
the
fix/slow-plugins
branch
from
January 20, 2026 21:45
35a824e to
1038fc1Compareneriousy
marked this pull request as ready for review
January 20, 2026 22:04
neriousy
marked this pull request as draft
January 20, 2026 22:36
neriousy
marked this pull request as ready for review
January 20, 2026 22:48
neriousy
commented
Jan 20, 2026
ContributorAuthor
tests failing cause new config.get() does some more blocking for the dependency installation - will figure it out tommorow |
neriousyforce-pushed
the
fix/slow-plugins
branch
from
January 21, 2026 16:36
54a515e to
e6030deCompareneriousyforce-pushed
the
fix/slow-plugins
branch
from
January 21, 2026 17:23
e35f2a5 to
19c2aa4CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
thdxrforce-pushed
the
dev
branch
3 times, most recently
from
January 30, 2026 14:37
f1ae801 to
08fa7f7Compare
Comment on lines
23
to
36
| async function waitFor(check: () => boolean, timeoutMs = 8_000) { | ||
| const start = Date.now() | ||
| async function loop(): Promise<void> { | ||
| if (check()) return | ||
| if (Date.now() - start > timeoutMs) { | ||
| throw new Error(`Timed out waiting for condition after ${timeoutMs}ms`) | ||
| } | ||
| await new Promise((resolve) => setTimeout(resolve, 10)) | ||
| return loop() | ||
| } | ||
| await loop() | ||
| } | ||
| // Mock UnauthorizedError |
Collaborator
There was a problem hiding this comment.
are these changes actually needed??
ContributorAuthor
There was a problem hiding this comment.
I reverted those change but threw in a bigger timeout singe Config.get() takes a little longer now
rekram1-node
commented
Feb 3, 2026
Collaborator
/review |
Contributor
lgtm |
Uh oh!
There was an error while loading. Please reload this page.
ishaksebsib pushed a commit
to ishaksebsib/opencode
that referenced
this pull request
Feb 4, 2026
ishaksebsib pushed a commit
to ishaksebsib/opencode
that referenced
this pull request
Feb 4, 2026
Colin4k1024 pushed a commit
to Colin4k1024/opencode
that referenced
this pull request
Feb 10, 2026
3 tasks
schneiderlo pushed a commit
to schneiderlo/opencode
that referenced
this pull request
Feb 17, 2026
xywsxp pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
Rwanbt pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
AIALRA-0 pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
avion23 pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
Rwanbt pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
MarsQiu007 referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Plugins
@latestwere always reinstalled even if their version was cachedHow did you verify your code works?
Check in the logs whether plugins are installed twice
For example
Run without any plugins
Add
oh-my-opencodeIt should say in the logs that it's installing
Run again and it shouldn't install it anymore