feat: Add support for Ollama and Qdrant API keys - #4
Open
sealad886 wants to merge 1 commit into
Open
Conversation
sealad886
commented
Nov 21, 2025
- Updated package.json to include yargs and its types for argument parsing.
- Enhanced configuration interfaces to support optional Ollama and Qdrant API keys.
- Modified CLI argument parser to accept --ollama-api-key and --qdrant-api-key options.
- Updated NodeConfigProvider to handle new API key configurations.
- Enhanced CodeIndexConfigManager to store and validate Ollama API keys.
- Updated Ollama embedder to include API key in requests.
- Improved Qdrant client to handle API key authentication.
- Added network capture utility to log HTTP requests to Qdrant and Ollama.
- Implemented smoke tests for Qdrant connection and Ollama API key functionality.
- Updated ConfigPanel to display masked API keys for security.
- Updated package.json to include yargs and its types for argument parsing. - Enhanced configuration interfaces to support optional Ollama and Qdrant API keys. - Modified CLI argument parser to accept --ollama-api-key and --qdrant-api-key options. - Updated NodeConfigProvider to handle new API key configurations. - Enhanced CodeIndexConfigManager to store and validate Ollama API keys. - Updated Ollama embedder to include API key in requests. - Improved Qdrant client to handle API key authentication. - Added network capture utility to log HTTP requests to Qdrant and Ollama. - Implemented smoke tests for Qdrant connection and Ollama API key functionality. - Updated ConfigPanel to display masked API keys for security.
sealad886
commented
Nov 21, 2025
Author
Oh this also re-vamps CLI argument parsing so that it now imports yargs and uses that more common library instead of the big list of if-then checks that were there before. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for optional API key authentication for both Ollama and Qdrant services. The changes introduce CLI arguments (--ollama-api-key and --qdrant-api-key), update configuration interfaces to support API keys, and modify the HTTP clients to include Authorization headers when API keys are provided. The PR also includes smoke test utilities and updates the TUI ConfigPanel to display masked API keys for security.
Key Changes
- Migrated CLI argument parsing from manual string parsing to
yargslibrary for more robust argument handling - Added optional API key support for Ollama embeddings and Qdrant vector store with proper header configuration
- Implemented API key masking in UI displays for security
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added yargs and @types/yargs dependencies for improved CLI argument parsing |
| package-lock.json | Updated lock file with yargs dependencies and transitive dependency changes |
| src/cli/args-parser.ts | Replaced manual argument parsing with yargs library; added ollama-api-key and qdrant-api-key options |
| src/cli/tui-runner.ts | Updated to pass API key CLI overrides to configuration system |
| src/abstractions/config.ts | Added ollamaApiKey field to ConfigSnapshot interface |
| src/adapters/nodejs/config.ts | Enhanced to handle API key CLI overrides for both Ollama and Qdrant |
| src/code-index/interfaces/config.ts | Added optional apiKey field to OllamaEmbedderConfig interface |
| src/code-index/config-manager.ts | Added ollamaApiKey storage and validation; updated restart detection logic |
| src/code-index/embedders/ollama.ts | Modified to include Authorization header when API key is provided |
| src/code-index/service-factory.ts | Updated to pass API key to Ollama embedder constructor |
| src/code-index/vector-store/qdrant-client.ts | Enhanced constructor to set Authorization header for API key authentication |
| src/examples/tui/ConfigPanel.tsx | Added maskKey function and UI display for masked API keys |
| src/test-ollama-api-key.ts | Added basic smoke test for Ollama API key initialization (test doesn't verify actual behavior) |
| src/smoke-test-qdrant.ts | Added comprehensive smoke test for Qdrant connection with API key support |
| src/network-capture.ts | Added HTTP proxy utility for debugging/logging requests to Ollama and Qdrant |
| autodev-config.json | Updated example config to include apiKey and qdrantApiKey fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Create the captured request object | ||
| const captured: CapturedRequest = { | ||
| id: Math.random().toString(36).substr(2, 9), |
There was a problem hiding this comment.
The method substr() is deprecated. Use substring() or slice() instead.
Suggested change
| id: Math.random().toString(36).substr(2,9), | |
| id: Math.random().toString(36).slice(2,11), |
| export const ConfigPanel: React.FC<ConfigPanelProps> = ({ config, onConfigUpdate, onLog }) => { | ||
| const maskKey = (key?: string) => { | ||
| if (!key) return 'Not set'; | ||
| if (key.length <= 3) return '*'.repeat(key.length); |
There was a problem hiding this comment.
The masking logic exposes too much information for very short keys. For keys of length 3 or less, the entire key length is revealed through the number of asterisks. Consider using a fixed masking pattern (e.g., always show "..." or similar) to avoid leaking key length information.
Suggested change
| if(key.length<=3)return'*'.repeat(key.length); | |
| if(key.length<=3)return'**...**'; |
| */ | ||
| import { createServer, IncomingMessage, ServerResponse } from 'http'; | ||
| import { parse } from 'url'; |
There was a problem hiding this comment.
Unused import parse.
Suggested change
| import { parse } from 'url'; |
| import { QdrantClient } from "@qdrant/js-client-rest"; | ||
| import { fileURLToPath } from 'url'; | ||
| import { dirname } from 'path'; |
There was a problem hiding this comment.
Unused import dirname.
Suggested change
| import { dirname } from 'path'; |
| */ | ||
| import { CodeIndexOllamaEmbedder } from './code-index/embedders/ollama'; | ||
| import { ApiHandlerOptions } from './shared/api'; |
There was a problem hiding this comment.
Unused import ApiHandlerOptions.
Suggested change
| import { ApiHandlerOptions } from './shared/api'; |
| // Test 1: Initialize embedder without API key | ||
| console.log('\n📋 Test 1: Initialize embedder without API key'); | ||
| const embedderWithoutKey = new CodeIndexOllamaEmbedder({ |
There was a problem hiding this comment.
Unused variable embedderWithoutKey.
Suggested change
| constembedderWithoutKey=newCodeIndexOllamaEmbedder({ | |
| newCodeIndexOllamaEmbedder({ |
| // Test 2: Initialize embedder with API key | ||
| console.log('\n📋 Test 2: Initialize embedder with API key'); | ||
| const embedderWithKey = new CodeIndexOllamaEmbedder({ |
There was a problem hiding this comment.
Unused variable embedderWithKey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.