Skip to content
This repository was archived by the owner on Apr 20, 2021. It is now read-only.

[ios_l3_interfaces] with supported operations - #18

Open
justjais wants to merge 36 commits into
ansible:develfrom
justjais:ios_l3_interface
Open

[ios_l3_interfaces] with supported operations#18
justjais wants to merge 36 commits into
ansible:develfrom
justjais:ios_l3_interface

Conversation

@justjais

Copy link
Copy Markdown

No description provided.

@ansible-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@ansible-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@justjais
justjais marked this pull request as ready for review June 5, 2019 14:41
@ansible-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@justjaisjustjais changed the title Draft for IOS L3 interface<WIP>IOS L3 interface with supported operationsJun 6, 2019
@ansible-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@ansible-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@ansible-zuul

Copy link
Copy Markdown
Contributor

Build failed.

@ikhan2010

Copy link
Copy Markdown
Collaborator

@justjais can you please fix the linting issues?

@ansible-zuul

Copy link
Copy Markdown
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

justjais added 20 commits June 28, 2019 17:10
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
justjais added 14 commits June 28, 2019 17:10
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansible-zuul

Copy link
Copy Markdown
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@NilashishCNilashishC left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to assert before, after and list of commands generated. The ordering of the before/after list of dictionaries are not consistent across consecutive runs in different environments, which may result in integration test failures in Zuul (as observed with VyOS tests in Zuul). Since we don't have an identifier for the dicts generated, we need to convert them to a set and then assert (using symmetric_difference), thereby making sure that changes in ordering does not affect test results.

@ikhan2010ikhan2010 changed the title IOS L3 interface with supported operations[ios_l3_interfaces] with supported operationsJul 15, 2019
@ansible-zuul

Copy link
Copy Markdown
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@ansible-zuul

Copy link
Copy Markdown
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@justjais@ikhan2010@NilashishC