Terraform docker splunk deployment by CSL-Answer · Pull Request #124 · answerdigital/AnswerKing-CS

CSL-Answer · 2023-03-16T14:56:09Z

Added config for deploying Splunk in an EC2 instance.

The terraform code is within it's own folder to avoid destroying other defined infrastructures.

PietroConvalleAD · 2023-03-16T15:41:54Z

I think you could just add it along with the rest of the terraform code, so you can reuse the same LB rather than having a separate project

… in order to be visible

* Bump Microsoft.AspNetCore.Mvc.Testing from 7.0.3 to 7.0.4 Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 7.0.3 to 7.0.4. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.3...v7.0.4) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): update packages.lock.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Alba from 7.3.0 to 7.4.0 Bumps [Alba](https://github.com/JasperFx/alba) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/JasperFx/alba/releases) - [Commits](JasperFx/alba@v7.3.0...v7.4.0) --- updated-dependencies: - dependency-name: Alba dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): update packages.lock.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump AWSSDK.CloudWatchLogs from 3.7.104.33 to 3.7.104.40 Bumps [AWSSDK.CloudWatchLogs](https://github.com/aws/aws-sdk-net) from 3.7.104.33 to 3.7.104.40. - [Release notes](https://github.com/aws/aws-sdk-net/releases) - [Commits](https://github.com/aws/aws-sdk-net/commits) --- updated-dependencies: - dependency-name: AWSSDK.CloudWatchLogs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): update packages.lock.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

bethcryer

Checkov has flagged some issues in the pipeline that need addressing. If the rule they're complaining about isn't valid, you can add an exception in the terraform code.

…esource

… be implemented in a future security update

…module

github-actions · 2023-04-17T14:43:24Z

Tests run with 277 passed and 0 failed in 22845ms.

sonarqubecloud · 2023-04-17T14:45:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

CSL-Answer added 3 commits March 15, 2023 14:47

First completed draft of splunk terraform file.
b20d8ff

Fixed source urls for modules
afe2d74

splunk config now successfully runs a splunk instance
46356d1

CSL-Answer requested a review from bethcryer March 16, 2023 14:56

This comment has been minimized.
Sign in to view

bethcryer suggested changes Mar 17, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/versions.tf Outdated
Comment threadterraform/splunk/splunk.tf
Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf Outdated

code style ammendments
b9e07db

This comment has been minimized.
Sign in to view

moved splunk variables to local folder for the splunk terraform code,…
7fb54f5
… in order to be visible

This comment has been minimized.
Sign in to view

Added checkov skip comments to avoid the unneeded analysis errors
05b9eb8

This comment has been minimized.
Sign in to view

dependabotBotand others added 4 commits March 23, 2023 10:11

successfully applied however, broke current splunk instance
4391999

This comment has been minimized.
Sign in to view

bethcryer suggested changes Mar 24, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf

PietroConvalleAD reviewed Mar 27, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated

PietroConvalleAD reviewed Mar 27, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf

updated route 53 record code
64facca

This comment has been minimized.
Sign in to view

PietroConvalleAD reviewed Mar 27, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated

PietroConvalleAD reviewed Mar 27, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated

PietroConvalleAD reviewed Mar 27, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated

bethcryer suggested changes Mar 27, 2023
View reviewed changes

Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf
Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf Outdated
Comment threadterraform/splunk/splunk.tf

CSL-Answer added 2 commits March 28, 2023 11:41

subnet mapping now configured for one subnet
1b0f2bf

Added S3 bucket for splunk
5f423d6

This comment has been minimized.
Sign in to view

bethcryer suggested changes Apr 4, 2023
View reviewed changes

bethcryer reviewed Apr 5, 2023
View reviewed changes

Comment threadterraform/versions.tf Outdated

removed docker provider
30015bc

CSL-Answer dismissed PietroConvalleAD’s stale review via 30015bcApril 5, 2023 12:35

This comment has been minimized.
Sign in to view

s3 access logs and related config added
572da90

This comment has been minimized.
Sign in to view

enabled deletion protection for load balancer
5b8fcbc

This comment has been minimized.
Sign in to view

Added skip for aws autoscaling EC2 launch template checkov check
d2c53e7

This comment has been minimized.
Sign in to view

Skipped checkov check for S3 bucket event notifications
7a6f5d9

This comment has been minimized.
Sign in to view

Skipped check for EC2 lanch templates for the aws_autoscaling_group r…
a10a2ed
…esource

This comment has been minimized.
Sign in to view

Checkov check for KMS encryption on S3 buckets has been skipped. Will…
a91ff96
… be implemented in a future security update

This comment has been minimized.
Sign in to view

Added checkov skips for the elb_logs resource
c0d6e37

This comment has been minimized.
Sign in to view

Set associate public ip address to false for the splunk ec2 instance
68d7a0d

This comment has been minimized.
Sign in to view

Load balancer for splunk is not using TLS 1.2
ec869d2

This comment has been minimized.
Sign in to view

Added versioning for the elb logs s3 bucket
fca116d

This comment has been minimized.
Sign in to view

updated ec2 instance set up to use the new version 2.1.0 for the ec2 …
33f9c62
…module

This comment has been minimized.
Sign in to view

Successfully applies with ec2 update
6936d3d

Uh oh!

Conversation

CSL-Answer commented Mar 16, 2023

Uh oh!

This comment has been minimized.

PietroConvalleAD commented Mar 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bethcryer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actionsBot commented Apr 17, 2023

Uh oh!

sonarqubecloudBot commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants