refactor without (direct) dynamic allocation - #20
Closed
fperrad wants to merge 3 commits into
Closed
Conversation
the C stack is good enough
(which is the string buffer included in Lua)
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
cmsgpack is a much better Lua citizen now because we use the memory allocator assigned to our lua_State instead of grabbing memory from the system ourselves. Typically the memory allocator is just the system's realloc, but some use cases involve providing custom allocation routines (for accounting or performance or limiting memory). This closesantirez#20 too because those commits were just trying to remove the previous direct allocation behavior. All tests pass under Lua 5.1 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
cmsgpack is a much better Lua citizen now because we use the memory allocator assigned to our lua_State instead of grabbing memory from the system ourselves. Typically the memory allocator is just the system's realloc, but some use cases involve providing custom allocation routines (for accounting or performance or limiting memory). This closesantirez#20 too because those commits were just trying to remove the previous direct allocation behavior. All tests pass under Lua 5.1 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 7, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 11, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 11, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now - closesantirez#31 - fix comment typos I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
mattsta added a commit
to mattsta/lua-cmsgpack
that referenced
this pull request
Apr 14, 2014
Changes: - Improve table vs. array detection - Improve packing +-inf - Add multiple pack/unpack support - Add cmsgpack.safe module variant - Add local build infrastructure for easier testing - Add user-controlled unpack support limiting returned objects - Add Lua 5.3 compatibility - Remove an unnecessary malloc - Use Lua memory allocator instead of malloc for buffer creation Issues involved: - closesantirez#16 - allow multi pack/unpack by default - closesantirez#10 - unpack one/limit API added - closesantirez#13 and closesantirez#20 - use Lua allocator - closesantirez#15 - (included in antirez#16) - ignores antirez#22 because it's confusing - closesantirez#23 - fixed elsewhere - closesantirez#26 - extracted some useful parts from a difficult commit - closesantirez#28 - we started tagging versions again recently - closesantirez#27 - that failure case works for me now - closesantirez#31 - fix comment typos I merged commits with original author information where possible, but each commit required manual cleanup of one or more of: formatting fixes (no tabs, please), commit message fixes (more details please), extracting contents from a single 300 line commit with 5 different logical changes merged together, and general correctness checking after merging with newer code. As of this commit, all tests pass on Lua 5.1.5 and Lua 5.3-work2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the issue http://github.com/antirez/lua-cmsgpack/issues/13