Remove warning, fix double free, bump version - #29
Merged
Conversation
We don't need 'max' because 'idx' is monotonically increasing, so when we exit the loop, 'idx' is 'max' by definition. Removes compile-time warning of: lua_cmsgpack.c: In function 'table_is_an_array': lua_cmsgpack.c:370:21: warning: variable 'max' set but not used [-Wunused-but-set-variable] long count = 0, max = 0, idx = 0; ^
(discovered by scan-build)
Use a more forgiving version comparison for the future. This change future-proofs compatability against any potential upcoming versions 503, 504, 601, .... (assuming these API changes remain stable).
It's been two years since 0.3.0 and there have been a few small changes since then (including 5.2 compat). Cutting a new version allows other projects (and rocks) to pull down additions easier. Also adding a rockspec for 0.3.1 (tag 0.3.1 should be made on the origin repo so rocks can pull properly).
antirez added a commit
that referenced
this pull request
Apr 4, 2014
Remove warning, fix double free, bump version
antirez
commented
Apr 4, 2014
Owner
Thank you Matt 👍 , merged. Please if you find more time to take care of lua-cmsgpack, try to look at #16. Thanks! |
mattsta
commented
Apr 4, 2014
ContributorAuthor
Thanks! I'll see what I can do about #16 now that I'm stuck in Lua mode for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four tiny fixes here: