Implement real GIS processors and converters for Datasets module - #107
Merged
Conversation
Replace all stub processors and converters with working implementations that shell out to GDAL/OGR and tippecanoe for GIS file processing: Processors (metadata extraction on upload): - CogProcessor: gdalinfo -json for raster metadata - ShapefileProcessor: unzip + ogrinfo/ogr2ogr for zipped shapefiles - KmlProcessor: ogrinfo/ogr2ogr for KML files - GeoPackageProcessor: ogrinfo/ogr2ogr for GPKG files - PmTilesProcessor: binary v3 header reader with correct spec offsets Converters (format conversion): - VectorToPmTilesConverter: tippecanoe CLI for GeoJSON → PMTiles - RasterToCogConverter: gdal_translate -of COG for raster → COG Infrastructure: - CliRunner: shared async process runner with concurrent stdout/stderr draining to prevent pipe-buffer deadlocks - TempDirectory: IDisposable temp dir wrapper with auto-cleanup Bug fixes: - Register dataset jobs via AddModuleJob instead of AddScoped so the worker's JobTypeRegistry can discover and execute them - Add Lazy<IEventBus> to worker extensions (mirrors host) to fix crash when SettingsService resolves via AuditSaveChangesInterceptor - Fix ConvertDatasetJob to read from NormalizedPath for non-GeoJSON vector sources instead of the raw original file - Point worker appsettings at shared host database and storage paths
Deploying simplemodule-website with |
| Latest commit: | d1811f2 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a042376.simplemodule-website.pages.dev |
| Branch Preview URL: | https://feature-wonderful-leavitt.simplemodule-website.pages.dev |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliRunner(deadlock-safe process runner) andTempDirectory(auto-cleanup) infrastructure helpersLazy<IEventBus>missing), job discovery (AddModuleJobinstead ofAddScoped), and conversion of non-GeoJSON vector sources (read from normalized GeoJSON cache)Processors (metadata extraction on upload)
gdalinfo -jsonunzip+ogrinfo+ogr2ogrogrinfo+ogr2ogrogrinfo+ogr2ogrConverters (format conversion)
tippecanoe(zoom 0-14)gdal_translate -of COG -co COMPRESS=DEFLATEBug fixes
DatasetsModule.cs: Register jobs viaAddModuleJob<T>()soJobTypeRegistrydiscovers themSimpleModuleWorkerExtensions.cs: AddLazy<IEventBus>registration (mirrors host) to fix worker crashConvertDatasetJob.cs: Read fromNormalizedPathfor non-GeoJSON vector sourcesWorker/appsettings.json: Point at shared host database and storage paths for local devTest plan
/api/datasets/{id}/download?variant=