docs(frontend): use the real PageShell in the layout example (closes #196) - #208
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes #196. The "full docs review & sync" (#205) replaced almost every nonexistent frontend hook/component reference, but left one in the Layouts JSX-composition example in
docs/frontend/pages.md:PageHeaderis one of the nonexistent components #196 is about — it isn't exported anywhere inpackages/ui. This swaps it for the realPageShellpage wrapper (and adds it to the import), matching the rest of the docs.After this, a repo-wide grep for the names #196 enumerated (
useAuth,useMenus,useFlash,PageHeader,DataTable,@simple-module-py/i18n-react) is clean.Issues closed