Skip to content

docs(frontend): use the real PageShell in the layout example (closes #196) - #208

Merged
antosubash merged 1 commit into
mainfrom
fix/docs-pageheader-pageshell
Jun 8, 2026
Merged

docs(frontend): use the real PageShell in the layout example (closes #196)#208
antosubash merged 1 commit into
mainfrom
fix/docs-pageheader-pageshell

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

Completes #196. The "full docs review & sync" (#205) replaced almost every nonexistent frontend hook/component reference, but left one in the Layouts JSX-composition example in docs/frontend/pages.md:

<AuthenticatedLayout><PageHeadertitle="Orders"/> // PageHeader is not exported by @simple-module-py/ui
...
</AuthenticatedLayout>

PageHeader is one of the nonexistent components #196 is about — it isn't exported anywhere in packages/ui. This swaps it for the real PageShell page wrapper (and adds it to the import), matching the rest of the docs.

After this, a repo-wide grep for the names #196 enumerated (useAuth, useMenus, useFlash, PageHeader, DataTable, @simple-module-py/i18n-react) is clean.

Issues closed

Note: #197 and #198 were also fully addressed by #205 already — they can be closed directly (no diff needed); this PR only carries the one residual #205 missed.

…ut example
The #205 docs sync left one `<PageHeader title="Orders" />` in the Layouts
JSX-composition example (pages.md). PageHeader is not exported by
`@simple-module-py/ui` — it is one of the nonexistent components #196 is about.
Use the real `PageShell` page wrapper instead.
Fixes#196
@antosubash
antosubash merged commit b5e6e7f into mainJun 8, 2026
11 of 12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant

@antosubash