Skip to content

fix: remove footer from the branding - #275

Merged
antosubash merged 1 commit into
mainfrom
pi/issue-273-remove-footer-from-the-branding
Aug 21, 2026
Merged

fix: remove footer from the branding#275
antosubash merged 1 commit into
mainfrom
pi/issue-273-remove-footer-from-the-branding

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Closes#273

Headless Pi worker

This is a draft pull request created from an issue carrying the approval label.
It is never merged automatically and requires human review.

Agent summary

Summary

  • Removed configurable footer ownership from the branding module, including API routes, settings, contracts, shared props, editor components, and localization keys.
  • Restored framework-owned footer rendering in site layouts.
  • Updated branding documentation and added regression coverage confirming footer routes return 404.

Changed areas

  • modules/branding/
  • packages/ui/
  • Generated packages/i18n/src/*
  • Branding documentation

Verification

  • uv run --all-packages pytest modules/branding/tests114 passed
  • npx vitest run packages/ui/src/components/BrandingFooter.test.tsx3 passed
  • make lintpassed
  • uv run --all-packages python -m simple_module_core0 errors, one unrelated existing SM003 AuditLog warning
  • git diff --checkpassed

Evidence / risks

  • Visual evidence: none.
  • Existing persisted footer setting rows are left inert rather than destructively deleted.
  • No blockers.

Local visual evidence

When requested, screenshots, traces, videos, and GIFs are stored only under the worker worktree's ignored
.qa/issues/273/ directory. GitHub CLI cannot attach those files; inspect them on the worker host
or attach selected evidence manually.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with Cloudflare Pages Cloudflare Pages

Latest commit:dd65a1a
Status: ✅ Deploy successful!
Preview URL:https://080ce6d0.simple-module-python.pages.dev
Branch Preview URL:https://pi-issue-273-remove-footer-f.simple-module-python.pages.dev

View logs

@antosubash
antosubash marked this pull request as ready for review August 21, 2026 12:55
@antosubash

Copy link
Copy Markdown
OwnerAuthor

/pi review

@antosubash

Copy link
Copy Markdown
OwnerAuthor

✅ Feedback processed with no tracked code changes.

  • Feedback:/pi review requested a review but contained no actionable change request.
  • Response: Inspected the implementation; no additional changes were needed. Worktree remains clean.

Checks

  • Branding tests: 20 passed
  • BrandingFooter tests: 3 passed
  • Ruff and Biome checks: passed
  • git diff --check: passed

Evidence: None required.
Blockers: No substantive maintainer feedback was provided to address.

@antosubash
antosubash merged commit bbde959 into mainAug 21, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove footer from the branding

1 participant

@antosubash